> On April 24, 2017, 4:51 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > > Line 681 (original), 681 (patched) > > <https://reviews.apache.org/r/58668/diff/1/?file=1698104#file1698104line681> > > > > Why not supply them anymore? Seems like a performance penality if you > > pass in `null` > > Laszlo Puskas wrote: > +1
In this branch `clusterName == null` => `cluster == null` => `desiredConfigs == null` always. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58668/#review172788 ----------------------------------------------------------- On April 24, 2017, 4:43 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58668/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 4:43 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, > and Sebastian Toader. > > > Bugs: AMBARI-20832 > https://issues.apache.org/jira/browse/AMBARI-20832 > > > Repository: ambari > > > Description > ------- > > Fix trivial typo. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > f604a7f8be9b2dad7810e46444ae79ead73f8a98 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > ac6ac1d299947a3b4ba0f0f41f7a6f851b2a72db > > > Diff: https://reviews.apache.org/r/58668/diff/1/ > > > Testing > ------- > > Unit tests: `HostResourceProviderTest` passed, other unit tests pending. > > > Thanks, > > Attila Doroszlai > >
