----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58674/#review172821 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On April 24, 2017, 1:13 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58674/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 1:13 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-20833 > https://issues.apache.org/jira/browse/AMBARI-20833 > > > Repository: ambari > > > Description > ------- > > On clusters which are large (1000's of hosts, 10's of 1000's of components), > prior upgrades which have been finalized can cause problems when starting > future upgrades: > > AMBARI-20672 partially fixes this by keeping the {{UpgradeEntity}} > association in even during suspended upgrades. Therefore, a query against > {{HostRoleCommandDAO}} isn't needed anymore. However, if an upgrade is in > progress, we must still walk the upgrade to determine if the > {{UpdateDesiredStackAction}} has been called yet. This calculation can be > cached and invalidated to prevent the need to traverse a massive upgrade > hierarchy. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java > 3d304ea > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 9594803 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 6b39afa > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterEffectiveVersionTest.java > 9d339e2 > > > Diff: https://reviews.apache.org/r/58674/diff/2/ > > > Testing > ------- > > Tests run: 4985, Failures: 0, Errors: 0, Skipped: 39 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:46 min > [INFO] Finished at: 2017-04-24T10:51:37-04:00 > [INFO] Final Memory: 62M/778M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
