----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58665/#review172830 -----------------------------------------------------------
Fix it, then Ship it! ambari-agent/src/main/python/ambari_agent/Controller.py Lines 611 (patched) <https://reviews.apache.org/r/58665/#comment245862> This would fail with a version that contains more than 1 digit between dots. Change to [\d+.]+ - Alejandro Fernandez On April 24, 2017, 12:41 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58665/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 12:41 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20822 > https://issues.apache.org/jira/browse/AMBARI-20822 > > > Repository: ambari > > > Description > ------- > > Ambari agent printed the following error (albeit as a logger.info) during > start up when its version is 1.2.3.0_MyAgent. > INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in > move_data_dir_mount_file(). Error: invalid literal for int() with base 10: > '0_MyAgent' > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c > ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451 > > > Diff: https://reviews.apache.org/r/58665/diff/1/ > > > Testing > ------- > > exiting unit tests, new unit test, patched a cluster with the fix and verify > the error message message was gone. > > > Thanks, > > Di Li > >
