-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58710/
-----------------------------------------------------------
Review request for Ambari, Miklos Gergely and Oliver Szabo.
Bugs: AMBARI-20845
https://issues.apache.org/jira/browse/AMBARI-20845
Repository: ambari
Description
-------
This patch resolves AMBARI-20845.
Since the LogSearch service in Ambari 2.5.1 will be updated to support
archiving log data from multiple clusters, the LogSearch Integration in Ambari
should be updated in order to pass the name of the current cluster, since the
Logsearch Server may be supporting multiple clusters.
This patch implements the following:
1. The LoggingRequestHelperImpl will now include a "clusters" query parameter
with each request, and use the current cluster name as the value.
2. Existing unit tests have been updated with new assertions to make sure that
this query parameter is set as expected.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
2b1b04a
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
b24500f
Diff: https://reviews.apache.org/r/58710/diff/1/
Testing
-------
1. Manually verified this change on a local Vagrant 3-node LogSearch cluster.
Verified with LogSearch logging and ambari-server logging that the new
"clusters" query parameter is set as expected. Also verified that the LogSearch
Integration is working as expected with this change applied.
2. Ran the ambari-server unit tests (all passing).
Thanks,
Robert Nettleton
