----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58723/#review173041 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java Lines 105 (patched) <https://reviews.apache.org/r/58723/#comment246125> Interesting variable name. Did the 90s call? :) ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java Lines 133 (patched) <https://reviews.apache.org/r/58723/#comment246123> nit: formatting ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java Lines 153 (patched) <https://reviews.apache.org/r/58723/#comment246124> nit: formatting - Nate Cole On April 25, 2017, 10:40 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58723/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:40 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole. > > > Bugs: AMBARI-20851 > https://issues.apache.org/jira/browse/AMBARI-20851 > > > Repository: ambari > > > Description > ------- > > Components can become {{OUT_OF_SYNC}} before and after stack upgrades. As a > result, this can affect the success of future upgrade attempts. It seems > wrong to expose a direct way to alter this state since it's calculated from > the agents. > > - The logic currently for reporting component versions is as follows: > -- On an agent's initial heartbeat registration, status commands will report > component versions. Subsequent status commands will not. > -- On any START/STOP/RESTART, the component will report a version > > This means that if a host is {{OUT_OF_SYNC}} there are two ways to > automatically fix it (assuming the cluster is properly upgraded) > - Restart the agent on that host > - Restart the components which are {{OUT_OF_SYNC}} on that host > > It would be good to notify the cluster administrator that there is a problem > with the reported version of the components. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/alerts/AlertRunnable.java > ea583e4 > > ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java > PRE-CREATION > ambari-server/src/main/resources/alerts.json d646401 > > ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58723/diff/1/ > > > Testing > ------- > > Tests run: 5006, Failures: 0, Errors: 0, Skipped: 39 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 16:37 min > [INFO] Finished at: 2017-04-25T20:25:20-04:00 > [INFO] Final Memory: 55M/522M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
