-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58857/
-----------------------------------------------------------
(Updated April 29, 2017, 10:42 a.m.)
Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro
Lisnichenko, and Nate Cole.
Bugs: AMBARI-20894
https://issues.apache.org/jira/browse/AMBARI-20894
Repository: ambari
Description
-------
Long story short here is that this is the first major breaking change for
supporting service/patch upgrades. Some highlights:
- Services and components will now track their "desired repository"
- The cluster_version is deprecated and I've removed the use of it in many
places in order to get this compiling. It will be further removed by a future
commit
- The host components are now compared to their components to verify if the
upgrade has succeeded
- Some things are still very wrong
-- I have about 300 unit test compile errors. Once I fix those, I'm sure they
will all fail. It's something we plan to fix in iterations as more code is
changed to support service and patch
-- There are DDL changes here; we will do the work to upgrade the database in a
separate Jira
-- Lots of useless code has been removed
-- The python code still doesn't understand per-component versions; that is a
follow-up Jira.
Please review and keep in mind that many areas are partially complete since
there are many other Jiras tracking this work. That's why it's in a feature
branch :)
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py
da47351
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
c1028dc
ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
7dfbe47
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
b2a03e4
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
04b72ea
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
c3e66fc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
ff8d0be
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
6556852
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
623851a
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java
abf8e6b
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java
930a535
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
ea2938b
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java
4ed9617
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceComponentDesiredStateEntity.java
17fd323
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
885f995
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
5d73fac
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckAction.java
52c0cf2
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
32d6151
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
7bcb9d0
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java
1ef204d
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
5964e33
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java
b5b6821
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
104e456
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
4cfb250
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
a3a041b
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
a0c0db1
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
97f5003
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
92e01c2
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
228cf79
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
f1e93ac
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
6c59784
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
0aab0b5
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeUtil.java
b258aa8
ambari-server/src/main/python/ambari-server.py 737be6a
ambari-server/src/main/python/ambari_server/serverUpgrade.py 6f17900
ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b241dc2
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 670bf17
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 00b3248
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f6af968
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 64a0137
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 22b2c3d
ambari-server/src/test/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnableTest.java
98f6f44
ambari-server/src/test/python/TestAmbariServer.py 9579c22
ambari-server/src/test/python/TestServerUpgrade.py 9235ff9
Diff: https://reviews.apache.org/r/58857/diff/2/
Changes: https://reviews.apache.org/r/58857/diff/1-2/
Testing
-------
I upgraded a single service and did a happy dance when it finalized. That's
about the best we're going to get with this patch...
Thanks,
Jonathan Hurley
