----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review173806 -----------------------------------------------------------
ambari-web/app/controllers/wizard/step8_controller.js Lines 1814 (patched) <https://reviews.apache.org/r/58864/#comment246843> this may be my preference, but can we use method name like "hostInExistingHostGroup" ? then later on, your logic would look like self.hostInExistingHostGroup. ambari-web/app/controllers/wizard/step8_controller.js Lines 1816 (patched) <https://reviews.apache.org/r/58864/#comment246844> spacing ambari-web/app/controllers/wizard/step8_controller.js Lines 1923 (patched) <https://reviews.apache.org/r/58864/#comment246846> can we use cluster name as the blueprint name ? then later on when we add the popup alert dialog telling users what to do with the bp and cluster template, we can give them some examples with the cluster name mentioned as the bp name. ambari-web/app/messages.js Lines 128 (patched) <https://reviews.apache.org/r/58864/#comment246842> Can we use "Generate Blueprint" or something hinting the files will be generated ? - Di Li On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58864/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 9:06 p.m.) > > > Review request for Ambari, Di Li, Jaimin Jetly, Jayush Luniya, Robert > Nettleton, Sangeeta Ravindran, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-20698 > https://issues.apache.org/jira/browse/AMBARI-20698 > > > Repository: ambari > > > Description > ------- > > UI be able to export a blueprint when a user reaches the Deploy page and the > bp can be used to install a cluster later on. > This patch exports blueprint and template. Currently HostGroups are formed > only based on the component mapping. In this patch configGroups are not > addressed. ConfigGroup and other improvements will be addressed in next > revisions of this functionality. > > > Diffs > ----- > > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > ambari-web/app/messages.js 8f8d981af7 > ambari-web/app/templates/wizard/step8.hbs ac32710468 > > > Diff: https://reviews.apache.org/r/58864/diff/1/ > > > Testing > ------- > > Manual Testing done. I have attached blueprint.json and clustertemplate.json > files that are currently generated with this patch applied. > > > File Attachments > ---------------- > > exported_blueprint > > https://reviews.apache.org/media/uploaded/files/2017/04/28/897160b1-46d8-49d1-bc87-f14249718c26__exported_blueprint_.json > exported_clustertemplate > > https://reviews.apache.org/media/uploaded/files/2017/04/28/e53d037e-a77e-487e-ac08-ce754e4afc97__exported_clustertemplate.json > > > Thanks, > > Amruta Borkar > >
