-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58981/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Robert Levas.
Bugs: AMBARI-20925
https://issues.apache.org/jira/browse/AMBARI-20925
Repository: ambari
Description
-------
As per the Role based access control list, users with Service Administrator
role should be able to manage service auto-start while users with Service
Operator role should not have this privilege.
Currently, the following 2 issues are seen:
1. Service Operators can view Service Auto Start menu item which is not as per
the accesss control list.
2. Service Administrators cannot enable or disable auto-start at service level
because clicking on the Service Auto Start menu item returns them to the main
services dashboard.
The menu item is displayed incorrectly fot Service Operators because we are
checking for SERVICE.START_STOP and CLUSTER.MODIFY_CONFIGS privileges. If user
has either privilege, we display the menu. To fix this, we need to add a check
for SERVICE.MANAGE_AUTO_START and CLUSTER.MANAGE_AUTO_START. If the user has
either of these privileges, then the menu item should be enabled.
Also, when the menu is clicked, we are checking only for
CLUSTER.MANAGE_AUTO_START privilege but not for SERVICE.MANAGE_AUTO_START
(which is the privilege that Service Administrators have). Hence, for Service
Administrators, clicking on the menu results in incorrect navigation to the
dashboard instead of displaying the Service Auto Start page. To fix this, we
need to add a check for SERVICE.MANAGE_AUTO_START privilege as well.
Diffs
-----
ambari-web/app/routes/main.js 1f881e0
ambari-web/app/views/main/admin.js 0fa84e8
ambari-web/app/views/main/menu.js 6e79aba
Diff: https://reviews.apache.org/r/58981/diff/1/
Testing
-------
Manual Testing with all 5 roles and Ambari admin.
mvn clean test.
Thanks,
Sangeeta Ravindran
