----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58984/#review173924 -----------------------------------------------------------
In all the pom.xml's, there are two contrib/views/files/pom.xml Lines 183 (patched) <https://reviews.apache.org/r/58984/#comment247003> I tested the patch locally. This is a general comment that applies to all pom.xml file changes. We can't have two arguments tags here like this, because the last one will overwrite the first one. So essentially, yarn is being run with "yarn --ignore-engines". Also, --pure-lockfile argument is missing in this particular pom.xml. - Yusaku Sako On May 4, 2017, 6:36 a.m., venkat sairam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58984/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 6:36 a.m.) > > > Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, > Nitiraj Rathore, Pallav Kulshreshtha, Rohit Choudhary, Sumit Mohanty, and > Yusaku Sako. > > > Bugs: AMBARI-20928 > https://issues.apache.org/jira/browse/AMBARI-20928 > > > Repository: ambari > > > Description > ------- > > npm package manager have been replaced with yarn manager and front-end > plugins, node versions have been updated as per the requirements. > > > Diffs > ----- > > contrib/views/capacity-scheduler/pom.xml 181deb4 > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/capacity-scheduler/src/main/resources/ui/yarn.lock > PRE-CREATION > contrib/views/files/pom.xml 8e691b1 > contrib/views/files/src/main/resources/ui/package.json 24da458 > contrib/views/files/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hawq/pom.xml e4ed54a > contrib/views/hawq/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/hive-next/pom.xml a1e116d > contrib/views/hive-next/src/main/resources/ui/hive-web/bower.json d029eff > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive-next/src/main/resources/ui/hive-web/yarn.lock > PRE-CREATION > contrib/views/hive/pom.xml de83dbc > contrib/views/hive/src/main/resources/ui/hive-web/bower.json d029eff > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/src/main/resources/ui/hive-web/yarn.lock PRE-CREATION > contrib/views/hueambarimigration/pom.xml f7a42dd > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/package.json > 64b3270 > > contrib/views/hueambarimigration/src/main/resources/ui/hueambarimigration-view/yarn.lock > PRE-CREATION > contrib/views/jobs/pom.xml a8f44f3 > contrib/views/jobs/src/main/resources/ui/yarn.lock PRE-CREATION > contrib/views/pig/pom.xml cf2ed37 > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/pig/src/main/resources/ui/pig-web/yarn.lock PRE-CREATION > contrib/views/pom.xml 0a1a77f > contrib/views/wfmanager/pom.xml bcb9572 > contrib/views/wfmanager/src/main/resources/ui/package.json d04d57c > contrib/views/wfmanager/src/main/resources/ui/yarn.lock PRE-CREATION > pom.xml db3d457 > > > Diff: https://reviews.apache.org/r/58984/diff/1/ > > > Testing > ------- > > Manual testing done > > > Thanks, > > venkat sairam > >
