> On May 4, 2017, 3:07 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java > > Lines 146-153 (patched) > > <https://reviews.apache.org/r/58845/diff/1/?file=1703102#file1703102line146> > > > > Should this really be an exception if they are aleady linked, or can it > > be a information message with a NOOP?
This method is called both for autolinking and in the REST API to link a specific extension version to a stack version. Removing the exception would change the REST API and make it look like the call actually worked. The exception is caught and logged when autolinking. - Tim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58845/#review173909 ----------------------------------------------------------- On April 28, 2017, 5:48 p.m., Tim Thorpe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58845/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 5:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Jayush Luniya, and Nate Cole. > > > Bugs: AMBARI-20891 > https://issues.apache.org/jira/browse/AMBARI-20891 > > > Repository: ambari > > > Description > ------- > > It would possible to link extensions to supported stack versions while > parsing the stacks, extensions and common-services directories. > > This would allow extensions to avoid making rest API calls to set up the link. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce08 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ExtensionLinkDAO.java > 3df1cd5 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ExtensionLinkEntity.java > 12b3ce0 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java > ce92ecf > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > 20e28fc > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > d3ad351 > > ambari-server/src/main/java/org/apache/ambari/server/state/ExtensionInfo.java > 656a8ce > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 353dd86 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/ExtensionMetainfoXml.java > 77a7250 > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerExtensionTest.java > 9900eb5 > ambari-server/src/test/resources/extensions/EXT/0.1/metainfo.xml 77a832c > ambari-server/src/test/resources/extensions/EXT/0.2/metainfo.xml 04f733c > ambari-server/src/test/resources/extensions/EXT/0.3/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/extensions/EXT/0.3/services/OOZIE2/themes/broken_theme.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HBASE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/global.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hadoop-env.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-log4j.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HDFS/package/dummy-script.py > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/HIVE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/MAPREDUCE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_extensions/HDP/0.3/services/ZOOKEEPER/metainfo.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58845/diff/1/ > > > Testing > ------- > > mvn clean test > > mvn clean test -Dtest=StackManagerExtensionTest -DskipPythonTests > > > Thanks, > > Tim Thorpe > >
