> On May 11, 2017, 6:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > > Line 365 (original) > > <https://reviews.apache.org/r/59176/diff/1/?file=1715296#file1715296line366> > > > > Whenever we change any schema, we have to change the Upgrade Catalogs > > to upgrade existing clusters. > > > > I assume this is a breaking change that prevents SQL Server from even > > being used, so there are no successful cluster installs. > > > > Is that why this patch does not have any accompanying changes in the > > Upgrade Catalog?
Yes I hit into the issue when trying to create a cluster with Ambari using MS SQL. Cluster creation failed as insertion into request table were failing. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59176/#review174679 ----------------------------------------------------------- On May 11, 2017, 3:17 p.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59176/ > ----------------------------------------------------------- > > (Updated May 11, 2017, 3:17 p.m.) > > > Review request for Ambari, Dmytro Grinenko and Nate Cole. > > > Bugs: AMBARI-20988 > https://issues.apache.org/jira/browse/AMBARI-20988 > > > Repository: ambari > > > Description > ------- > > https://issues.apache.org/jira/browse/AMBARI-20919 moved the > cluster_host_info column from stage table into request table. The change > missed to cover the Ambari database schema DDL for MS SQL server. > > > Diffs > ----- > > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql b78e2a4 > > > Diff: https://reviews.apache.org/r/59176/diff/1/ > > > Testing > ------- > > Unit tests: > Results : > > Tests run: 4065, Failures: 0, Errors: 0, Skipped: 32 > > > ========== > docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P > "$MSSQL_PASSWORD" -i /tmp/ambari/Ambari-DDL-SQLServer-CREATE.sql > > (54 rows affected) > > (3 rows affected) > > (1 rows affected) > > (3 rows affected) > > (8 rows affected) > > (1 rows affected) > > (7 rows affected) > > (53 rows affected) > > (1 rows affected) > > (14 rows affected) > > (19 rows affected) > > (24 rows affected) > > (31 rows affected) > > (42 rows affected) > > (53 rows affected) > > (1 rows affected) > > (1 rows affected) > > > docker exec -it mssql /opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P > "$MSSQL_PASSWORD" > 1> select count(*) from ambari_sequences; > 2> go > > ----------- > 54 > > (1 rows affected) > > > Thanks, > > Sebastian Toader > >
