----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59229/#review174791 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On May 12, 2017, 10:02 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59229/ > ----------------------------------------------------------- > > (Updated May 12, 2017, 10:02 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21005 > https://issues.apache.org/jira/browse/AMBARI-21005 > > > Repository: ambari > > > Description > ------- > > We have code surrounding GSInstaller that looks ancient and should be removed. > > > Diffs > ----- > > ambari-server/pom.xml 8635608752 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/ClusterDefinition.java > 487ebffc74 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerClusterProvider.java > 784f51c275 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerComponentProvider.java > b0d953a748 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostComponentProvider.java > d35c2ceacc > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostProvider.java > 5b69da48e8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerNoOpProvider.java > af7ab29b4a > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerProviderModule.java > 018ae19756 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerResourceProvider.java > 7b76cb95fe > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerServiceProvider.java > 2438273908 > > ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerStateProvider.java > 3f9e27204d > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerClusterProviderTest.java > 7583e663e2 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerComponentProviderTest.java > 2e26ec9e20 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostComponentProviderTest.java > 2552fa43bb > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerHostProviderTest.java > beacc72242 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerNoOpProviderTest.java > 9d1f053016 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerServiceProviderTest.java > 5ea00a8a41 > > ambari-server/src/test/java/org/apache/ambari/server/controller/gsinstaller/TestGSInstallerStateProvider.java > a8e7a6d72e > > > Diff: https://reviews.apache.org/r/59229/diff/1/ > > > Testing > ------- > > mvn clean test > ran build and install > > > Thanks, > > Dmitro Lisnichenko > >
