----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59266/#review174949 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On May 15, 2017, 12:17 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59266/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 12:17 p.m.) > > > Review request for Ambari, Miklos Gergely, Robert Nettleton, Sandor Magyari, > and Sebastian Toader. > > > Bugs: AMBARI-21020 > https://issues.apache.org/jira/browse/AMBARI-21020 > > > Repository: ambari > > > Description > ------- > > Currently, logsearch it framework load story files (JBehave) from the > classpath, it would be useful to load story files externally, then we should > not manage story files inside the source code. (helps to write business > specific tests without code change) > > To achive this, add 2 new properties to the build: backend.stories.location > and ui.stories.location properties. > > > Diffs > ----- > > ambari-logsearch/README.md 92b98f9 > ambari-logsearch/ambari-logsearch-it/pom.xml 0058c80 > > ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchBackendStories.java > 46f2928 > > ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchStoryLocator.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/story/LogSearchUIStories.java > 217c50f > > > Diff: https://reviews.apache.org/r/59266/diff/2/ > > > Testing > ------- > > done. > > > Thanks, > > Oliver Szabo > >
