----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59306/#review175075 -----------------------------------------------------------
Ship it! Ship It! - Balázs Bence Sári On May 16, 2017, 9:24 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59306/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 9:24 a.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21029 > https://issues.apache.org/jira/browse/AMBARI-21029 > > > Repository: ambari > > > Description > ------- > > * added request, request wrapper, response > * documented API > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/SettingRequestWrapper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/SettingService.java > e186be2afc31b26895dc88a67d4c88c914eff19e > > ambari-server/src/main/java/org/apache/ambari/server/controller/SettingRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/SettingResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/SettingResourceProvider.java > e50490e5dd3aa8195dac36b2fb322408d7aab7df > > ambari-server/src/test/java/org/apache/ambari/server/api/services/SettingServiceTest.java > 1bc75ff38ccced3a4c5f03c6b67d9cfa316597d4 > > > Diff: https://reviews.apache.org/r/59306/diff/1/ > > > Testing > ------- > > * verified generated doc > * `SettingResourceProviderTest` and `SettingServiceTest` pass > > > Thanks, > > Attila Doroszlai > >
