----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59338/#review175273 -----------------------------------------------------------
Ship it! Ship It! - Anita Jebaraj On May 17, 2017, 5:09 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59338/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 5:09 p.m.) > > > Review request for Ambari, Anita Jebaraj, Laszlo Puskas, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-21043 > https://issues.apache.org/jira/browse/AMBARI-21043 > > > Repository: ambari > > > Description > ------- > > Backport Ambari-17694 to Ambari 2.5.1 because the patch was never committed > to branch-2.5 and thus did not make it into Ambari 2.5.0. > > Most of the changes from Ambari 2.4.x applied without much additional work, > however an upgrade path from Ambari 2.5.0 to Ambari 2.5.1 has been created > since users of Ambari 2.5.1 may have missed out on the needed changes. This > additional work was essentially copying > `org.apache.ambari.server.upgrade.UpgradeCatalog240#updateKAFKAConfigs` to > `org.apache.ambari.server.upgrade.UpgradeCatalog251#updateKAFKAConfigs` and > adding to the unit tests in > `org.apache.ambari.server.upgrade.UpgradeCatalog251Test`. > > See AMBARI-17694 for more information about the changes. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > 77333b8bc4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > cf0c37dd02 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog251.java > 146520fa11 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 1327090aa7 > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json > 60fa959f2d > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > d0f82af13d > > ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/kerberos.json > 501f969a93 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > 857047bd4d > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 8baf496474 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog251Test.java > 4575998c50 > > > Diff: https://reviews.apache.org/r/59338/diff/2/ > > > Testing > ------- > > Manually tested upgrades from Ambari 2.4.0 to Ambari 2.5.1, and from Ambari > 2.5.0 to Ambari 2.5.1 > > #Local test results: PENDING > > #Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
