> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > > Lines 1126 (patched) > > <https://reviews.apache.org/r/59369/diff/1/?file=1723973#file1723973line1143> > > > > Can you annotate this method declaration as being temporary? It should > > eventually not be needed, right?
This was added because we do the same checking on both the validation and the processing. I had missed code in one of the spots and had enough. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59369/#review175390 ----------------------------------------------------------- On May 18, 2017, 9:56 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59369/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 9:56 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and > Jonathan Hurley. > > > Bugs: AMBARI-21059 > https://issues.apache.org/jira/browse/AMBARI-21059 > > > Repository: ambari > > > Description > ------- > > With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the > notion of a cluster being bound to a specific stack. Instead, the stack ID is > being pushed down to the service and component level. > > Currently, upgrades tries to set the cluster desired stack ID on > finalization. Eventually there will be a complete decouple of the cluster > from a singular stack id. This jira covers a majority of cases in code. > Until configs are refactored, we can't remove the associated stack id in its > entirety. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java > 1d5ba0e9e9 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 36015282ea > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > a77ed75c99 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > 17e1f9c138 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > c655c6286f > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > 2fc1787e17 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java > 70a061cc79 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java > 1e87319d84 > > ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java > a4cea3105f > > ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java > a55a1481d6 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java > 4ccdc0a3d9 > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java > 273bdaac68 > > ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java > d8dba96094 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 9fb77e8d6b > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 397c1c29e1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java > 96bab85b47 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > a4f59a58eb > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > 8a5731bcbe > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java > 66c1a93081 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 4ad01a54a7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 9ca8ddc369 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 24ef41a767 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 664ba42f34 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java > 8972ca220f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > c3691bfa88 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > c69d00ba46 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > c4c2ddcbae > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java > 264ba030f7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java > d44515cdb4 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java > 89d4004f4f > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java > 0643c94ce1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java > 4d0cf92c87 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java > 24c460226c > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > 40ec0a1e80 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > a2472b6a8c > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > 47abde4660 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java > 7a99f09ff0 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 9098cf1da8 > ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java > aa53564661 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigFactory.java > d6cd99786c > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > 05b50ab915 > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java > 0e40254487 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 9a35bcc97f > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 3c8ef3530c > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 6bb0ffb25b > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 281523a660 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > bdc4f90f89 > > ambari-server/src/main/java/org/apache/ambari/server/state/configgroup/ConfigGroupImpl.java > a74e2a28d8 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java > dbfce48e8b > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > e08b1f9ba5 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > cb1295961d > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java > 38ad5baaec > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > edf107a9f4 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java > 7b7681c0fc > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java > 90854dd346 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog2121.java > 0487cd7024 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog220.java > 9cf7bbde4b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog221.java > c235cf8e08 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > f0f92537c0 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 8488795eac > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > 0125d54ac1 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java > d59d1d5c09 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalogTest.java > 4dd7fd9bb1 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java > 4ed7685ae3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog211Test.java > c705d89045 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog220Test.java > fc754a06fe > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java > f4b3897dee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java > 82ba1498de > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 70673f8114 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 3cb2c47075 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java > 8f1510b8a2 > ambari-web/app/controllers/wizard/step8_controller.js 4678d03a48 > > > Diff: https://reviews.apache.org/r/59369/diff/1/ > > > Testing > ------- > > Manual: Install cluster; add service; run service checks; deploy both patch > and full version; full and patch RU/EU. > > Automated pending unit test fixes. > > > Thanks, > > Nate Cole > >
