> On May 20, 2017, 7:10 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > > Line 26 (original), 27 (patched) > > <https://reviews.apache.org/r/59391/diff/2/?file=1724772#file1724772line27> > > > > The "dummy" interface `RequestPostRequest` also defines a > > `RequestResourceFilter`. Is this one really an `ApiModel`?
Th top level RequestResourceFilter class doesn't encapsulate all information contained by the schema, hence the new one. - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59391/#review175589 ----------------------------------------------------------- On May 22, 2017, 11:41 a.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59391/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 11:41 a.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21063 > https://issues.apache.org/jira/browse/AMBARI-21063 > > > Repository: ambari > > > Description > ------- > > Annotated RequrstServices and request/response models with Swagger > annotations. Sub-resources are skipped as Swagger doesn't support them out of > the box in their current form. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java > 936b857 > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPostResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestPutRequest.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestRequest.java > db9268b > > ambari-server/src/main/java/org/apache/ambari/server/controller/RequestResponse.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceFilter.java > 4028e35 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > 9704b33 > > > Diff: https://reviews.apache.org/r/59391/diff/3/ > > > Testing > ------- > > Unit tests pendig. > > > Thanks, > > Balázs Bence Sári > >
