----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59475/#review175750 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Line 1704 (original), 1710 (patched) <https://reviews.apache.org/r/59475/#comment249103> These 2 lines look off, shouldn't these be logged as well? ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java Line 1706 (original), 1712 (patched) <https://reviews.apache.org/r/59475/#comment249104> Lets add another line for changes configuration keys to indicate exact properties that were changed by the user. - Sid Wagle On May 23, 2017, 1:36 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59475/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 1:36 a.m.) > > > Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle. > > > Bugs: AMBARI-21096 > https://issues.apache.org/jira/browse/AMBARI-21096 > > > Repository: ambari > > > Description > ------- > > Improve logging of ambari-config-changes.log to include names, timestamps, > and versions. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 25b12de > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > cf6b717 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > c244107 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 228cf79 > > > Diff: https://reviews.apache.org/r/59475/diff/1/ > > > Testing > ------- > > Verified on live cluster > > > Thanks, > > Alejandro Fernandez > >
