----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59459/#review175815 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml Lines 52 (patched) <https://reviews.apache.org/r/59459/#comment249150> In order to change the value for existing clusters, will have to either change it during an Ambari Upgrade, i.e., UpgradeCatalog251.java ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py Lines 50 (patched) <https://reviews.apache.org/r/59459/#comment249148> Will need to call this same logic in the Storm Service Advisor for HDP 3.0 ambari-server/src/main/resources/stacks/stack_advisor.py Lines 2866 (patched) <https://reviews.apache.org/r/59459/#comment249142> Just import re at the top ambari-server/src/main/resources/stacks/stack_advisor.py Lines 2873 (patched) <https://reviews.apache.org/r/59459/#comment249145> If we want to preserve order, then we should append to klass_array only if it doesn't already exist in some set, as opposed to doing set(klass_array) ambari-server/src/main/resources/stacks/stack_advisor.py Lines 2876 (patched) <https://reviews.apache.org/r/59459/#comment249146> This will append a "," even if no elements follow it. Instead, use klass_list = ["'" + e + "'" for e in klass_set] updated_yaml_string = "[" + ",".join(klass_list) + "]" ambari-server/src/main/resources/stacks/stack_advisor.py Lines 2881 (patched) <https://reviews.apache.org/r/59459/#comment249147> Similar comment regarding the comma - Alejandro Fernandez On May 23, 2017, 4:58 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59459/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 4:58 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Repository: ambari > > > Description > ------- > > AMBARI-21045. Enable Storm's AutoTGT configs in secure mode. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-env.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/STORM/1.1.0/configuration/storm-site.xml > 1a5dde9c16 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 8b5c07dc90 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > 5aa08c5369 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml > d98bb53a2a > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml > b3d19d42e1 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 4a2a502a20 > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml > 1eb9836abb > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml > a29f74b668 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > 8c659ee469 > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > 3054ca30c1 > ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py > 488562bf11 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml > 1610bb5580 > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > 1cdd184529 > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml > 3e7e3d7f14 > ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6c63 > > > Diff: https://reviews.apache.org/r/59459/diff/6/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
