> On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > > Lines 19 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730396#file1730396line19> > > > > Use braces and add javadoc
Included javadoc and braces in the new patch > On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 972 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730398#file1730398line972> > > > > We should allow special characters in passwords I have added this validation only for username, password allows special characters. I have matched the validation for username to be the same as in UI > On May 23, 2017, 10 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/serverSetup.py > > Lines 975 (patched) > > <https://reviews.apache.org/r/59503/diff/1/?file=1730398#file1730398line975> > > > > May want to check that it isn't a list of spaces either. I have added a strip() for admin_user, which would remove the leading and trailing white spaces, verified this behavior in the UI as well - Anita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59503/#review175864 ----------------------------------------------------------- On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59503/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 11:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, > Robert Levas, and Tim Thorpe. > > > Bugs: AMBARI-21083 > https://issues.apache.org/jira/browse/AMBARI-21083 > > > Repository: ambari > > > Description > ------- > > Provide the ability to create custom admin user during ambari server setup, > so that the user will have the option to either create the admin user with > the username/password of their preference or can use the default username. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 114046f > > ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java > PRE-CREATION > ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 > ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59503/diff/2/ > > > Testing > ------- > > Added 1 test case > > > Ran mvn test > > > File Attachments > ---------------- > > custom_admin.PNG > > https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG > > > Thanks, > > Anita Jebaraj > >
