> On May 24, 2017, 4:31 p.m., Sangeeta Ravindran wrote:
> > Ship It!

Hi Sangeeta, can you please help pushing the changes?


- Anita


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59496/#review175952
-----------------------------------------------------------


On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59496/
> -----------------------------------------------------------
> 
> (Updated May 23, 2017, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, 
> Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21095
>     https://issues.apache.org/jira/browse/AMBARI-21095
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Enable views to be opened in a new tab instead of being opened in the same 
> tab, this would help in going between the different tabs to look for 
> information or for config updates in the services.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> b6ec61d 
>   ambari-web/app/controllers/main/views_controller.js 398cdd8 
>   ambari-web/app/models/view_instance.js d438640 
>   ambari-web/test/controllers/main/views_controller_test.js 0ab7654 
>   ambari-web/test/models/view_instance_test.js 0e977e3 
> 
> 
> Diff: https://reviews.apache.org/r/59496/diff/1/
> 
> 
> Testing
> -------
> 
> Modified the test cases,
> 
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Reply via email to