----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59639/#review176425 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 1153 (patched) <https://reviews.apache.org/r/59639/#comment249789> I think the method should be named `isPlaceholder`, since the pattern has nothing to do with addresses. It may be reused for other properties. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java Lines 1154 (patched) <https://reviews.apache.org/r/59639/#comment249787> `PLACEHOLDER` should be a `static final` member, not a local variable, since the pattern does not change. ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java Lines 453 (patched) <https://reviews.apache.org/r/59639/#comment249788> `assertTrue(... != null)` can be simplified as `assertNotNull(...)` - Attila Doroszlai On May 30, 2017, 9:44 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59639/ > ----------------------------------------------------------- > > (Updated May 30, 2017, 9:44 p.m.) > > > Review request for Ambari, Di Li and Robert Nettleton. > > > Bugs: AMBARI-21137 > https://issues.apache.org/jira/browse/AMBARI-21137 > > > Repository: ambari > > > Description > ------- > > During upgrade Biginsights stack tokenizes value for > 'yarn.resourcemanager.webapp.https.address', therefore this property gets > removed by SingleHostUpdater during blueprint export. Next time when the > blueprint is used to create a cluster, this property is assigned default > value 'localhost' and exception is thrown. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 508bf1552d > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 24fc3c7435 > > > Diff: https://reviews.apache.org/r/59639/diff/1/ > > > Testing > ------- > > Updated test cases to address the scenario. > > > Thanks, > > Amruta Borkar > >
