----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59682/#review176435 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On May 31, 2017, 1:07 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59682/ > ----------------------------------------------------------- > > (Updated May 31, 2017, 1:07 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and > Sebastian Toader. > > > Bugs: AMBARI-19149 > https://issues.apache.org/jira/browse/AMBARI-19149 > > > Repository: ambari > > > Description > ------- > > * eliminate unnecessary `toString()` calls > * avoid concatenation and `String.format` in `debug()` and `trace()` calls > * replace few remaining commons-logging usages with SLF4J > * make sure `Logger LOG` is `final`, too > > > Diffs > ----- > > ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e > > ambari-server/src/main/java/org/apache/ambari/server/KdcServerConnectionVerification.java > 19b13aabdccfae0284950ff73cad6aa9b5ebe8ef > > ambari-server/src/main/java/org/apache/ambari/server/StateRecoveryManager.java > 826f2cabe313a2c9b297ee761dd01cd361c8d19f > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java > 982316dd3a24e1dca11935507b43cb630572f15f > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionManager.java > 3182b5070c1e852baf725fb79e0cdb1f11f4e158 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java > e779f78e03a481fb5c59f2ceb9d8b77bea2bbed2 > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java > ff67eeaa290a1b209272b6e9e92c2b6a89d5fd66 > ambari-server/src/main/java/org/apache/ambari/server/agent/ActionQueue.java > 02f2dc8edb71898ce7032d262ac00c374d85c561 > > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentRequests.java > 5ff15642a8b9ae0870df7aa6145b7d245e47e9a3 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 419cae43c28a90e4209fee6789531213862642f8 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > a19025249476735b17a187ec0e6272363791a0bd > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > 95f9b9ebb10475287ce2b95f69a8369604aca599 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java > 6649f8ac9e2751dfcee91112280d65c7a124915a > ambari-server/src/main/java/org/apache/ambari/server/agent/HostInfo.java > ce16f14a411705a8faee21f1ec6a532524e3d70e > ambari-server/src/main/java/org/apache/ambari/server/agent/Register.java > ec41a7bcc7ca23ab27a912c25db5a104a289e06f > > ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java > 0690f7b1991047680b2d5d28711d3871c35980be > > ambari-server/src/main/java/org/apache/ambari/server/api/query/QueryImpl.java > 1387dedf063bb9f2d236a0752b62c39025344996 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java > e5e1aa6f46a1c6d626abe842fd3b2f177a453754 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 7e8d3cad60fc36f1af535349e11e3b78d92cfa95 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java > bf4d9307ee9c5ae8d9f22e0f670aa66e903202ed > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java > 6a6b413a9d5719b68772b12205d2f9ea4612554b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java > b83534554cb81573ee9b87a3fdfd61dfff762ead > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java > 7731b222a6704217ae7f683de6de5becbc50f603 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > e4e2305dc9bbe83bd3773a8c273ef0b1c3827276 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewDataMigrationService.java > 3b9c58d19b6ff234b2671d0919ec415edd00ecdf > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSHostStatusCollector.java > fa8a22afbf5bae89e158df46221c0094ee075619 > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java > c2909a614189b7ea5e2061c95f98450cc8d09987 > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BootStrapImpl.java > c166326ac7b435a22ec9066d844a588cc014ce86 > > ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java > 4fdecc75c843df945aa46b16fce30defd937ccea > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 52a8987d638b721e3da8a8ba7d9bb7c39621f9be > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 0739a2a57f1970059ae342587b35442205850a2c > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariHandlerList.java > 9645a3689f09f379983d3074dcb4b0b9b6e99909 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 68af5f7815dc274ea660e77b26e30d4c6829c615 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 2f799b70c4562ec1377e2770cb09cb85fe2ba8c6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 4fa236225df2f4bcddae9563fc28ffa60b327890 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java > f7f20cc86d18801074f8bbd686a92c4837b6129a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java > 897583743198b3059d3761dd6e936599f75c7e53 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java > db9842aec2fa3ae2b6cb635723efe6ec79e850f1 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AppCookieManager.java > 790459300c7297bcd88fc31edf32d9cdc22f167d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java > 8c68a122391dff2f932d32a297e53019335dc00f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 508bf1552d9fda067a3dd4829d2087964bcb4d10 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 4dfcc3d4f817b8227f8c7c2b3f5f1dfd50437279 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java > 1949d06d4f0c7936808aafcd2f7e2f66d307342f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > cc3234b3534bbb0ff9336464b481bf713bfba7bb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java > ba6195f421b0a71b1673b7433a29159f7a3b8a17 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 06ff885dc9bca044679244b07a3266f5c8975091 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java > e3846ac37374ed5c6bc512e17b5ec390e933d0d7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java > ba6023940cb0682d8c0fb0c45d7552ec7ccf3713 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > a6cf66c3b6824bd193b1b3b1e7d7a67b649bdfd0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 5579792b21e01366a6143f9e2514ac991c16f82d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStatusHelper.java > 11512c4d69d8be0df02b1b3c6c98f8039e4affeb > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java > 2080e93f8bada0d02fdec99520517b891a1b7e6a > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java > 48a9b478a346cd1c12cae55229dac79d922b0804 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > afbd981c3b4f809100435ab21364a8bcb1b37d44 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java > f41eb263c87285689a2439858baf73f1f548b733 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java > 476c3d4429477d364f647bd9b5e12eab3d219454 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 4a9223f6eb9f553e41ff71a8ae48e46985032309 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/TaskAttemptResourceProvider.java > 2165fc76600046b7f1b10b78f18213dcb98371a6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/URLStreamProvider.java > ff36d9b665bd072b57b5f3bf85b721f3f36a9326 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java > 2ec63dbaeb8d7d7b90287d80048c3342042b793d > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProvider.java > 494f32bd95c396816ed50ce4902fb38ebaee1835 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/WorkflowResourceProvider.java > e3935bbc16953cd09457f24b7f1d3d5365c4d841 > > ambari-server/src/main/java/org/apache/ambari/server/controller/jmx/JMXMetricHolder.java > 53479192fc104895f63c9b73d3da9a8ff80ca2d2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java > 4370cfcb201a6e95395f0fc2cb3d785de320d7a3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java > 7e7656dde9eead51e9228892774d217395382157 > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java > ed4e102d3138fa6e68aab721f7d9241d36461e7d > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java > b1dfed9147e8e6b965f6c7bff9861a3e3960cf7c > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsDownsamplingMethod.java > 8044c7bc8a5ba50ca0c816d3cc2a14087b8b2b03 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java > 6d67dc84aaab58f3e508a0e7a20621eca843f89f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java > efb9d2d8704bbfe327fd5eb2a1b92b9b791d643f > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java > 472e3ead38939f1a574841b17c55060ddee9b273 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java > b9f3e0feb092c6d80b3e518ddd910b5005fbd440 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricsCacheSizeOfEngine.java > 1470da978d2cf7c9d12c4e69d17b486841396652 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/KerberosChecker.java > 5097c0960633bbea8b5469bad26bc7c347ca4c92 > > ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/ServiceCalculatedStateFactory.java > d95a7532d5c10c631cd749db6b0a993b4f68e504 > > ambari-server/src/main/java/org/apache/ambari/server/credentialapi/CredentialUtil.java > e6d7a37790f5b41dd2690da68701a2ac06b4d5cb > > ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java > 9260993b328e5ecde55a21df9ac70d82ab002a80 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java > 2d3743021a02564904313037b88dce93490315cc > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertLifecycleListener.java > 31c2f4acd2c871ad3861656c6af085001339f5a0 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java > 64372e0a8809f2aaf7438a399e26a11a788d4352 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceComponentHostListener.java > ec61e8c55bf58a43e5f565e054a0e239384726ed > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java > 7a936fee6c90ddbc1c4193877f7d4ad6caa849db > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertStateChangedListener.java > bc24b6d6fabb6fb58fd88b1ad1e5916262a31f26 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java > 178b7e96b06e2d3446a3a95590de2c43752587ec > > ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java > a874f9962c4f789887e312e663d9d33ec197278a > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > 6232859c6097c1e461ea89f34265b2ec0131a04b > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariPerformanceMonitor.java > 3453a22b1f01ce7354c971b6cb8f0103309403c1 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/DatabaseMetricsSource.java > 7062af1a9c1e2afd5820b6b82f8236c64b6d0456 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java > 41229cc803f9fb9dd7c4eabea199f047fe02fafe > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsConfiguration.java > a940a685b4377d63252d5fcde7215f0ff10cbd14 > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java > ac5b6c2684ea5b72b448e6f3d0f7ef3c1a13e0c3 > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > 3b07bc6cf80c2a45ddd24aede0107b579e61a6d8 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java > 297aef4937b37481ce44af5d23f64cfa2b0af3c6 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > f65ed007eff6e69d02e85fc27ef7c902c2a88c25 > > ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/dbms/GenericDbmsHelper.java > 7e3092d3f3a02680d646d829f176dd91f1328e7c > > ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceManager.java > 627af41868c7723c2f6530ff43af4394c02d1f33 > > ambari-server/src/main/java/org/apache/ambari/server/resources/api/rest/GetResource.java > 53266c2c07e5a681ce0616629ee3e76288b7175e > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/AbstractLinearExecutionJob.java > 0e6fc7b60d3891aa6b564fbbc0aa34301d1c672f > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java > 91f642ede94d50af89afefc5b435391aba5c4157 > > ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionSchedulerImpl.java > cd210b5c2d06020e8684aa3af78328a43023fbb5 > > ambari-server/src/main/java/org/apache/ambari/server/security/CertificateManager.java > 60d7a528e303a9c967d016adbb0b29f81ddac961 > > ambari-server/src/main/java/org/apache/ambari/server/security/SecurityFilter.java > f2f4d4f864a47dde73eaba6c74233c9a6d1df860 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java > a6ffa81d24514cfd9bdb145d3db00ec9bae0a4a3 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java > 0fff8c81226308dc6fad5728eb4b2609d6158e56 > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/jwt/JwtAuthenticationFilter.java > 258e9da30328c0a0f3a3fddbf711d37964910daf > > ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyServiceImpl.java > 4763cc25625ba2dfc0d6a906056af4928284fc44 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateDownload.java > b1ad05fc68421acb89c4f7b2f2cc987dbc07ddab > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateSign.java > 9f4cdd57fca82910657bc0da224c7db47a3b3476 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java > 6bce0b937b398145a50c604793ee20403934c15d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java > b2dbd5ef0a4a701cb93a118a5e26d40f60176069 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > 9ee5f1188af88b15253dd9ae13bb4d6a6f6726a9 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java > fc2de99aaacc8a70968df27e4fe2e6904220e738 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java > 54b4cd37c3916325e9cad9a8c9ada5ec243b4a7d > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java > 55d7366e1d99b7557a3be449b234b10deb633319 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java > b55c52f2e9f902e6a032111fd57a40fad940e015 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 439c10b7e9069c30a8f6a84d3a301806b6496ee9 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java > dfd3215acac533813303e47b24c861e326af0b7e > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionDirectory.java > 1f6ce2cb2e61f2aafd98e1411e8954c5f7041272 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ExtensionModule.java > ee4245a4ec119cdf9da0b8d187b485ab519d70e4 > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > daa53a6b4583c4e8fba30d0170035328e85f942c > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > e4dd85351548c78347288b91290932232a537f59 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > 7dbc63917302f0f55567b3411f8e86000221e418 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java > 16c8fd62b4655541f1946144c3bf743de9f0c405 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > d9649b91f1061916a9e2664630a39ab946216553 > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > 5dd7656c27dd43efefb82a1034bbf8a4a1cac2bf > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > 024a5e1207f61f17fe1eba403aace97486dd902b > ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java > 5ea039cd8605f889f7771983bcf5783019acb65e > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 65ebb2450338db491c1136cf5a74716a3918e179 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 006cbbc80a9aa8508929ed3491fde1c73148b76f > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > ca7794e2010690d5ce6634711bd7305184b1aaf9 > > ambari-server/src/main/java/org/apache/ambari/server/state/action/ActionImpl.java > b42a0b699d9c8e8219b8060cb4ec5f0932e6820d > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 03e5d11caa016518739e877e01a44c36f2f9582c > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > a95f90003885c99af7748f3e072ede037f28c5e0 > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java > 04aba31a7c7547abff11387e529d9ab66277157c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/ConfigUpgradePack.java > c5a7e180302a744c90a21e68f534b3dbc82ab14e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/StackRoleCommandOrder.java > cda9ab03fc4a580c553efc69465d5a0e2192224c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > b8e57c7c5c2352b8f04137e7a8fb6bf12172ed17 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > b19d72d09950c50bbe93b166537129929a3cabf7 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java > 452b66ace5702aae962d67d906dbc5059c4fe374 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > 58d63b3e6cbec98787abef25358287ba5bf8ff48 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 3cd34e4714ba600ed64ca22f7257f8ac1df382dd > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RestartGrouping.java > 0e3b4af11bfc6684431046429dd2351623f23cdb > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java > 967f3f76c710ef8c96a7befb88b1244dd0ecf9ac > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StartGrouping.java > d27e6d86b6f623aed5b1eceb9a5f0f38fdadd990 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StopGrouping.java > 44996c8876c3dd473618794eba83214648e2e22a > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapperBuilder.java > 98e873648abbdddce02fc6ae3dca4fdd7b435949 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > ec663a39d80915cabe820a75055c176ed8720d70 > > ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java > 4030e3ae38ceb81ef4f89a568a9c96454d32f082 > > ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/ConfigureClusterTask.java > 19d99ada3b02b3a6b6b23d2bf7596f2cd3c3d2d7 > > ambari-server/src/main/java/org/apache/ambari/server/topology/tasks/TopologyHostTask.java > 82a2f6e2f674cd031352ebfc2b59081eb1382333 > > ambari-server/src/main/java/org/apache/ambari/server/topology/validators/ClusterConfigTypeValidator.java > dce38b48d19a4a08de39097f1174dfc99714cec1 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 6c59784747e754dc1c80ad2094cd85ecc11f9f8b > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java > 48cf5f66a5d874bf39e511e643e3835e8ed72de2 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java > f0f92537c0f5bc8b9a73082bd628e8f0b47aaa6e > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > e911a216bd0e2c4b124f3b9eb0b679a4fe7774eb > ambari-server/src/main/java/org/apache/ambari/server/utils/AmbariPath.java > 790e0be09a0b0660cd5690e8aebba480dae08059 > > ambari-server/src/main/java/org/apache/ambari/server/utils/CommandUtils.java > 296e4d0ddfe0b813a9761a421d8d8a3ed6cc133b > > ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java > 2ab9ac56ae37608bc3133dd5a7fbd281b654d091 > > ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java > 4fcad3d0f2cab2262694523f32c809b82d558b12 > ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java > 1d21ccd9ee5a0902ec3f89252117d530238dec0d > > ambari-server/src/main/java/org/apache/ambari/server/view/HttpImpersonatorImpl.java > fc3f1d06afb0c5691865f4c53bf4c548cca12ff9 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java > dfa937e36cea46a9859402bc6ba211331e141e7b > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java > b62f4336280f1e9f88ab24b5b35cfc07f0e75efc > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationContextImpl.java > 0432265bd43e493feb7bf7118d08a3dbe2536c4f > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDataMigrationUtility.java > 0c827fed31728faf85d86259012c5b706f552c0b > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewDirectoryWatcher.java > 717bc657367e95bdfbdb66fa1d478f3d184ea31d > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java > 825a6c5dd5fa156b1e20b611cbc87df484e067b8 > ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java > dd633b32d3cd32c20380828f91baa7da059daea0 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java > 9c4459729af2380ae8f75aade8c8c5fafe2a886e > > ambari-server/src/test/java/org/apache/ambari/server/agent/AgentResourceTest.java > 5eb3186b290869203e637bb292cb02b8be6d8b85 > > ambari-server/src/test/java/org/apache/ambari/server/agent/LocalAgentSimulator.java > 9de1509945bbcbd57e182fd551f1dd7c81bad286 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestActionQueue.java > 0faa311eac94459a05d6b1e9bc5ba3dd2d49c5da > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > b54f64a597d15db1f2f03a64b601051246bf4c51 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > 6767a89c602730a5980a83fc93cc500c58d68ed6 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/PersistServiceTest.java > b68c666701a0a840ffb06580c4a6471cfd7a62ef > > ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapResourceTest.java > b99b17239914288d77fcdb145f0568c8b025974c > > ambari-server/src/test/java/org/apache/ambari/server/bootstrap/BootStrapTest.java > 91ca6447b9354d4f749d7240dacb743b477f44b9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > fcf99ba21e86057229bcaa9e4e505113904fcc83 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractJDBCResourceProviderTest.java > 07540bf639c245974b8282a64b766878c66285b5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java > 7cc67025e8ec6e0a3f27457a15d744bc70bf7006 > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/ganglia/GangliaMetricTest.java > 2df730b18bed63dbaa7e50c87cca1a0e6d6a35fc > ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java > 0d06d1321d29a42ae3b1017ae3229182bd811722 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java > 3146124ff4745148129df530d4aae9e9ac83fd9a > > ambari-server/src/test/java/org/apache/ambari/server/security/CertGenerationTest.java > 784fd86d47e370a5e426595ecadd9686632707a0 > > ambari-server/src/test/java/org/apache/ambari/server/security/SslExecutionTest.java > f91f5b70eb3799a176f24a01a17b815ec404e787 > > ambari-server/src/test/java/org/apache/ambari/server/security/encryption/MasterKeyServiceTest.java > f289c1132accf81f3902d64dcf9995c846ca1352 > > ambari-server/src/test/java/org/apache/ambari/server/stageplanner/TestStagePlanner.java > e493d82a01ab7fa3332ca9b7929064c4f9fb80fb > > ambari-server/src/test/java/org/apache/ambari/server/state/host/HostTest.java > 823199d887c9842ded79d6f95ae1ddb7c81efb40 > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 6a973a8aeced1849032eb5e8307d25074a2d0f8d > > ambari-server/src/test/java/org/apache/ambari/server/testing/DBInconsistencyTests.java > 506846b9b4685db364c629e4a7af6d1fbad17dee > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeTest.java > e311feab154fca8276476a721f16f80cfb50fe39 > > > Diff: https://reviews.apache.org/r/59682/diff/1/ > > > Testing > ------- > > ``` > $ mvn -am -pl ambari-server -DskipPythonTests > ... > Tests run: 4981, Failures: 0, Errors: 0, Skipped: 39 > ... > [INFO] BUILD SUCCESS > ``` > > > Thanks, > > Attila Doroszlai > >
