-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59440/#review176608
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 2708 (patched)
<https://reviews.apache.org/r/59440/#comment249975>

    Maybe make this a little clearer:
    
    The directory for scripts which are used by the alert notification 
dispatcher.


- Jonathan Hurley


On May 31, 2017, 9:37 p.m., yao lei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59440/
> -----------------------------------------------------------
> 
> (Updated May 31, 2017, 9:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21122
>     https://issues.apache.org/jira/browse/AMBARI-21122
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch will support using property 
> ambari.dispatch-property.script.filename in alert target to tell 
> AlertScriptDispatcher to lookup script by filename,default in  directory 
> /var/lib/ambari-server/resources/scripts. 
> 
> We can also change this directory in ambari.properties by 
> notification.dispatch.alert.script.directory property.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  84bfe52 
>   
> ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcherTest.java
>  f1f320d 
> 
> 
> Diff: https://reviews.apache.org/r/59440/diff/6/
> 
> 
> Testing
> -------
> 
> Tested in a cluster
> 
> 
> Thanks,
> 
> yao lei
> 
>

Reply via email to