> On June 1, 2017, 6:22 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/python/ambari-server.py > > Line 800 (original) > > <https://reviews.apache.org/r/59626/diff/1/?file=1734259#file1734259line800> > > > > Why is this added back? The upgrade stack option should be removed > > since it can't work in the world of patch/service upgrades.
it was a first revision of patch, I did not rebase it on top of commit that removes this code. Latest patch already has not that. - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59626/#review176616 ----------------------------------------------------------- On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59626/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 5:22 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-21091 > https://issues.apache.org/jira/browse/AMBARI-21091 > > > Repository: ambari > > > Description > ------- > > We decided to select exact package version by looking through repository for > target stack. > Also other minor fixes > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py > 8a15ee5ec5 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 054490b03e > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 975d6a63d8 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java > 8bfafd34bf > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > c12dff16b1 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java > 35fffda001 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py > 5f5576e3e7 > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > c6575b51a7 > ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py > fda63e099a > ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json > 51476031d8 > > > Diff: https://reviews.apache.org/r/59626/diff/2/ > > > Testing > ------- > > Live cluster tests > > > Thanks, > > Dmitro Lisnichenko > >
