> On June 6, 2017, 8:11 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > > Lines 527-530 (patched) > > <https://reviews.apache.org/r/59818/diff/1/?file=1741932#file1741932line542> > > > > Maybe add some doc since many won't know why this method is needed.
Will do. > On June 6, 2017, 8:11 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > > Lines 547-549 (patched) > > <https://reviews.apache.org/r/59818/diff/1/?file=1741932#file1741932line562> > > > > Any opinion about skipping components vs UNKNOWN? I suppose it's > > cleaner to omit them. That's a good point - is there benefit in knowing that something is deployed but isn't versionable? I'd like to take the path-of-need here; if it turns out we need it, it would be simple enough to add. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59818/#review177023 ----------------------------------------------------------- On June 5, 2017, 5:42 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59818/ > ----------------------------------------------------------- > > (Updated June 5, 2017, 5:42 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-21180 > https://issues.apache.org/jira/browse/AMBARI-21180 > > > Repository: ambari > > > Description > ------- > > Component scripts need to understand when they have been patched, and supply > the correct version number such that the correct scripts are used. > > This will involve sending the component version information in commands. > Some components that rely on others will need to construct commands correctly > (say, Oozie scripts that require HDP_VERSION environment variables) > > Remove: availableServices from the command json > Add: componentVersionMap as a structure of component name to version string > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > 2ec09d9fc9 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 17b89b7cc9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 76694d4455 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > cabb9d6c9e > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 881ef1a43a > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > 78ec165dad > > ambari-server/src/main/resources/common-services/STORM/1.0.1.3.0/package/scripts/params_linux.py > 78ec165dad > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > a6c0c32bc9 > > > Diff: https://reviews.apache.org/r/59818/diff/1/ > > > Testing > ------- > > Manual verification. Automated: > > [INFO] Starting audit... > Audit done. > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:18 min > [INFO] Finished at: 2017-06-05T17:32:00-04:00 > [INFO] Final Memory: 76M/797M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
