----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59886/#review177216 -----------------------------------------------------------
Ship it! Once this is committed, you should also update the Ambari wiki (the development section) to require this new min version now. - Jonathan Hurley On June 7, 2017, 12:55 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59886/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 12:55 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > Sumit Mohanty, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-21195 > https://issues.apache.org/jira/browse/AMBARI-21195 > > > Repository: ambari > > > Description > ------- > > Use Maven Enforcer plugin to specify minimum Maven version for > `ambari-server` module > > > Diffs > ----- > > ambari-project/pom.xml 98da9f4216b2e231f6a6bb855d6fd878b6d7066c > ambari-server/pom.xml c0aed7bbb381255cd2529d82baf34d677acbc94e > > > Diff: https://reviews.apache.org/r/59886/diff/1/ > > > Testing > ------- > > Build fails with message about Maven version when using old one: > > ``` > $ PATH=~/lib/apache-maven-3.0.5/bin:$PATH mvn -am -pl ambari-server validate > ... > [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ > ambari-server --- > [WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireMavenVersion > failed with message: > Detected Maven Version: 3.0.5 is not in the allowed range [3.3.9,). > ... > [INFO] BUILD FAILURE > ... > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce (enforce-maven) > on project ambari-server: Some Enforcer rules have failed. Look above for > specific messages explaining why the rule failed. -> [Help 1] > ``` > > Build succeeds when using 3.3.9 or newer: > > ``` > $ PATH=~/lib/apache-maven-3.3.9/bin:$PATH mvn -am -pl ambari-server validate > ... > [INFO] BUILD SUCCESS > ... > $ PATH=~/lib/apache-maven-3.5.0/bin:$PATH mvn -am -pl ambari-server validate > ... > [INFO] BUILD SUCCESS > ``` > > > Thanks, > > Attila Doroszlai > >
