> On June 8, 2017, 9:04 p.m., Richard Zang wrote: > > ambari-web/app/views/main/admin/stack_upgrade/services_view.js > > Line 59 (original), 59 (patched) > > <https://reviews.apache.org/r/59928/diff/2/?file=1744983#file1744983line59> > > > > This change is causing FE unit test failure, could you please fix the > > UT accordingly? > > > > To run FE unit test, go to /ambari-web and run "npm test" > > > > 30379 passing (23s) > > 157 pending > > 2 failing > > > > 1) Ambari Web Unit tests > > test/views/main/admin/stack_upgrade/services_view_test > > App.MainAdminStackServicesView #goToAddService() routes to Add Service > > Wizard and set redirect path on wizard close: > > expected false to be true > > > > > > 2) Ambari Web Unit tests > > test/views/main/admin/stack_upgrade/services_view_test > > App.MainAdminStackServicesView #goToAddService() routes to Security Wizard: > > expected false to be true
Thanks, Richard! Updated the UTs accordingly. - Duc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59928/#review177376 ----------------------------------------------------------- On June 8, 2017, 10:06 p.m., Duc Le wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59928/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 10:06 p.m.) > > > Review request for Ambari, Richard Zang and Yusaku Sako. > > > Bugs: AMBARI-21205 > https://issues.apache.org/jira/browse/AMBARI-21205 > > > Repository: ambari > > > Description > ------- > > AMBARI-21205 Make ToggleKerberos and AddDeleteService experimental features > > > Diffs > ----- > > ambari-web/app/config.js 451416d > ambari-web/app/routes/add_service_routes.js 13a1345 > ambari-web/app/routes/main.js 02b561d > ambari-web/app/templates/main/admin/kerberos.hbs 4f35fd5 > ambari-web/app/templates/main/service/all_services_actions.hbs 0ca1cd5 > ambari-web/app/views/main/admin.js 509f380 > ambari-web/app/views/main/admin/stack_upgrade/services_view.js f566814 > ambari-web/app/views/main/menu.js 00b1c38 > ambari-web/app/views/main/service/item.js 09457f2 > ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js > 70d182c > > > Diff: https://reviews.apache.org/r/59928/diff/3/ > > > Testing > ------- > > Manual build and E2E testing > > > Thanks, > > Duc Le > >
