----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59929/#review177441 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Toader On June 8, 2017, 11:37 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59929/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 11:37 p.m.) > > > Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, > Sumit Mohanty, and Sebastian Toader. > > > Bugs: AMBARI-21207 > https://issues.apache.org/jira/browse/AMBARI-21207 > > > Repository: ambari > > > Description > ------- > > Wrote a custom SwaggerReader in the utility project that handles nested > API's. There is currently one nested API which is annotated for swagger: > org.apache.ambari.server.api.services.ServiceService (nested under > ClusterService). Using the custom reader operation paths and parameters are > generated correctly for the nested API. > > > Diffs > ----- > > ambari-server/pom.xml c0aed7b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > f61fb2a > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java > a28c4aa > utility/pom.xml 7d5eb93 > utility/src/main/java/org/apache/ambari/swagger/AmbariSwaggerReader.java > PRE-CREATION > > utility/src/test/java/org/apache/ambari/swagger/AmbariSwaggerReaderTest.java > PRE-CREATION > utility/src/test/resources/log4j.properties PRE-CREATION > > > Diff: https://reviews.apache.org/r/59929/diff/1/ > > > Testing > ------- > > Tested Swagger API generation manually. Wrote new unit tests. Run all unit > tests for the ambari-server and utility projects, no errors or failures. > > > Thanks, > > Balázs Bence Sári > >
