----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59953/#review177507 -----------------------------------------------------------
Ship it! Ship It! - Tim Thorpe On June 9, 2017, 7:01 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59953/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 7:01 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-21213 > https://issues.apache.org/jira/browse/AMBARI-21213 > > > Repository: ambari > > > Description > ------- > > Consolidate UI for the "Loading..." text to use one label from message.js > > > Diffs > ----- > > > ambari-web/app/controllers/main/admin/highAvailability/progress_popup_controller.js > 7231e5c > ambari-web/app/messages.js 6f317a3 > ambari-web/app/templates/main.hbs bf6fa56 > ambari-web/app/utils/ajax/ajax.js 492a216 > ambari-web/app/views/common/configs/service_config_container_view.js > a7cee0c > ambari-web/app/views/loading.js 81d4a60 > ambari-web/app/views/main/alerts/definition_details_view.js 5c8efff > ambari-web/test/views/main/alerts/definition_details_view_test.js b3c4712 > > > Diff: https://reviews.apache.org/r/59953/diff/1/ > > > Testing > ------- > > unit tests. patch trunk cluster with changes. > > > Thanks, > > Di Li > >
