-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59948/
-----------------------------------------------------------
(Updated June 12, 2017, 8:03 p.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, Swapan
Shridhar, and Sid Wagle.
Bugs: AMBARI-20853
https://issues.apache.org/jira/browse/AMBARI-20853
Repository: ambari
Description
-------
See Epic AMBARI-20852
First step is to allow a Service's metainfo.xml file to define what type of
Service Advisor it uses, Python or Java.
For now, continue to call Python for all services since all services are not
specifying which type to use (so defaults to Python)
If set to Java, will eventually call a class to invoke the existing Service
Advisor in Python as a way to ensure compatibility.
If set to Python, continue to call the current script.
In both cases, we will continue to generate the services.json file.
Today, we call Stack Advisor on all services even if only one service is
modified, so it's ok to hardcode a service name until the UI is able to provide
that granularity.
Diffs (updated)
-----
ambari-client/groovy-client/pom.xml fa89a73
ambari-funtest/pom.xml 66678c2
ambari-infra/ambari-infra-solr-client/pom.xml 8cb2248
ambari-logsearch/ambari-logsearch-config-api/pom.xml 5355906
ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 7ecda60
ambari-logsearch/ambari-logsearch-it/pom.xml 81af9e8
ambari-logsearch/ambari-logsearch-logfeeder/pom.xml ddef52f
ambari-metrics/ambari-metrics-timelineservice/pom.xml f9d7e19
ambari-project/pom.xml 64d1416
ambari-server/checkstyle.xml 6b4824a
ambari-server/pom.xml 669f90f
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelper.java
3083d9f
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunner.java
a4b7915
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutRecommendationCommand.java
ca1d95f2
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ComponentLayoutValidationCommand.java
91d8f9c
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationDependenciesRecommendationCommand.java
fae0b16
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommand.java
e25e39b
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationValidationCommand.java
1892a82
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
ed27697
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java
7dbc639
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java
97490e0
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorHelperTest.java
e331ddd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRunnerTest.java
8d104ea
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/ConfigurationRecommendationCommandTest.java
17293eb
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommandTest.java
46552a3
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java
20d2168
ambari-views/examples/weather-view/pom.xml abed017
contrib/views/hawq/pom.xml 0c6591e
contrib/views/hive-next/pom.xml 578a82c
contrib/views/hive20/pom.xml 7ea95ad
contrib/views/pig/pom.xml 5239cc2
contrib/views/tez/pom.xml 170b89a
contrib/views/wfmanager/pom.xml a38cae5
pom.xml 8faec29
serviceadvisor/pom.xml PRE-CREATION
serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisor.java
PRE-CREATION
serviceadvisor/src/main/java/org/apache/ambari/serviceadvisor/ServiceAdvisorCommandType.java
PRE-CREATION
Diff: https://reviews.apache.org/r/59948/diff/3/
Changes: https://reviews.apache.org/r/59948/diff/2-3/
Testing
-------
mvn clean test passed
Verified on a live cluster.
Thanks,
Alejandro Fernandez
