-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59838/
-----------------------------------------------------------
(Updated June 13, 2017, 9:56 p.m.)
Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jonathan
Hurley, Jayush Luniya, and Nate Cole.
Changes
-------
Updated diff to fix the UI issue:
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py",
line 901, in sortServicesByDependencies
for component in service["components"]:
TypeError: 'NoneType' object is unsubscriptable
Bugs: AMBARI-20122
https://issues.apache.org/jira/browse/AMBARI-20122
Repository: ambari
Description
-------
After resolution of AMBARI-19685, stack advisor validates if stack defined
dependency is not satisfied but recommendation API does not account for this.
Stack defined dependencies are service/component based and has a scope
CLUSTER|HOST.
During recommendation the services to install have already been selected. We
can't really utilize the cluster scope because either the dependent service was
selected or it was not. If it was not selected it will be caught during
validation. We can only recommend based on HOST scope.
This JIRA is also limited to only handling those which don't have conditional
dependencies.
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/stack_advisor.py 4a81dc6
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
41c57f6
Diff: https://reviews.apache.org/r/59838/diff/4/
Changes: https://reviews.apache.org/r/59838/diff/3-4/
Testing
-------
Added new test case to test the recommendation of dependencies for slaves and
masters
mvn clean test -DskipSurefireTests
New trunk without my change
Total run:1168
Total errors:13
Total failures:0
New trunk with my change
Total run:1169
Total errors:13
Total failures:0
Thanks,
Tim Thorpe
