----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60033/#review177894 -----------------------------------------------------------
Fix it, then Ship it! Ship It! ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java Line 949 (original), 950 (patched) <https://reviews.apache.org/r/60033/#comment251591> We are losing task order here. Does that make a difference? ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java Line 276 (original), 276 (patched) <https://reviews.apache.org/r/60033/#comment251592> Request order is being lost. Could this cause an issue? - Robert Levas On June 13, 2017, 12:43 a.m., Sebastian Toader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60033/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 12:43 a.m.) > > > Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, Laszlo > Puskas, Robert Levas, Sandor Magyari, and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20749 > https://issues.apache.org/jira/browse/AMBARI-20749 > > > Repository: ambari > > > Description > ------- > > Adding a couple of fixes to > https://issues.apache.org/jira/browse/AMBARI-20687 and renaming the > db-cleanup functionality to db-purge-history > > > Diffs > ----- > > ambari-server/sbin/ambari-server 7044096 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 70c3661 > > ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupDriver.java > 788290b > > ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupService.java > 880207c > > ambari-server/src/main/java/org/apache/ambari/server/cleanup/CleanupServiceImpl.java > 29a9041 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java > b9e1fab > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java > 38c0977 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyHostTaskDAO.java > eea8032 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalRequestDAO.java > 32a38da > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/TopologyLogicalTaskDAO.java > 3a72aed > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyHostTaskEntity.java > 37830b7 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalRequestEntity.java > 1536b80 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/TopologyLogicalTaskEntity.java > 2954863 > ambari-server/src/main/python/ambari-server.py 235ef95 > ambari-server/src/main/python/ambari_server/dbCleanup.py 6e16bc5 > ambari-server/src/main/python/ambari_server/setupActions.py 358bfc9 > > ambari-server/src/test/java/org/apache/ambari/server/cleanup/CleanupServiceImplTest.java > 7de5aae > > > Diff: https://reviews.apache.org/r/60033/diff/1/ > > > Testing > ------- > > Manual testing: > ambari-server db-purge-history --cluster-name cl1 --from-date 2017-06-13 > > Verified that all request related records except the ones that belong to > upgrade were purged. > > > Unit tests: > > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 0.811 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.004 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 3.824 > s] > [INFO] utility ............................................ SUCCESS [ 1.411 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 0.387 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 7.708 > s] > [INFO] Ambari Server ...................................... SUCCESS [33:10 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:25 min > [INFO] Finished at: 2017-06-12T23:20:03+02:00 > [INFO] Final Memory: 56M/389M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sebastian Toader > >
