-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60048/#review177902
-----------------------------------------------------------


Fix it, then Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
Lines 671 (patched)
<https://reviews.apache.org/r/60048/#comment251600>

    The naming convention is to use the plural form of this... `COMMAS`.


- Robert Levas


On June 13, 2017, 9:18 a.m., Eugene Chekanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60048/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 9:18 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21238
>     https://issues.apache.org/jira/browse/AMBARI-21238
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> add comma separated rules to sasl.kerberos.principal.to.local.rules property 
> of server.properties
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AuthToLocalBuilder.java
>  33c8f3b 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.10.0.3.0/kerberos.json
>  eb31ad6 
>   ambari-server/src/main/resources/common-services/KAFKA/0.10.0/kerberos.json 
> eb31ad6 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 7500891 
>   
> contrib/management-packs/hdf-ambari-mpack/src/main/resources/stacks/HDF/2.0/services/KAFKA/kerberos.json
>  e1e6461 
> 
> 
> Diff: https://reviews.apache.org/r/60048/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Reply via email to