----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60086/#review177914 -----------------------------------------------------------
Ship it! Ship It! - Dmitro Lisnichenko On June 14, 2017, 6:12 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60086/ > ----------------------------------------------------------- > > (Updated June 14, 2017, 6:12 p.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Oliver Szabo, > and Sebastian Toader. > > > Bugs: AMBARI-21246 > https://issues.apache.org/jira/browse/AMBARI-21246 > > > Repository: ambari > > > Description > ------- > > Override inherited `execution` instead of defining new one. > > > Diffs > ----- > > ambari-agent/pom.xml c1cb056ac64d1c4d7a863ffb527dd0186cbed1ea > ambari-server/pom.xml ac78595d8665fc90c15c4638e583b72b42f5a19f > > > Diff: https://reviews.apache.org/r/60086/diff/1/ > > > Testing > ------- > > Built time is reduced from: > > ``` > $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean > package > ... > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 7.937 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.038 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 1.618 > s] > [INFO] utility ............................................ SUCCESS [ 1.881 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 0.738 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 4.212 > s] > [INFO] Service Advisor .................................... SUCCESS [ 0.497 > s] > [INFO] Ambari Server ...................................... SUCCESS [03:20 > min] > [INFO] Ambari Agent ....................................... SUCCESS [01:15 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 04:53 min > ``` > > to: > > ``` > $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean > package > ... > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 6.490 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.055 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 1.777 > s] > [INFO] utility ............................................ SUCCESS [ 2.110 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 0.933 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 6.133 > s] > [INFO] Service Advisor .................................... SUCCESS [ 0.691 > s] > [INFO] Ambari Server ...................................... SUCCESS [02:44 > min] > [INFO] Ambari Agent ....................................... SUCCESS [01:08 > min] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 04:12 min > ``` > > `tar.gz` is built exactly once: > > ``` > $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests clean > package > ... > [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ > ambari-server --- > [INFO] Reading assembly descriptor: src/main/assemblies/server.xml > ... > [INFO] Building tar : > ambari-server/target/ambari-server-2.0.0.0-SNAPSHOT-dist.tar.gz > ... > [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ > ambari-agent --- > [INFO] Reading assembly descriptor: src/packages/tarball/all.xml > ... > [INFO] Building tar : ambari-agent/target/ambari-agent-2.0.0.0-SNAPSHOT.tar.gz > ``` > > `tar.gz` can be skipped: > > ``` > $ mvn -am -pl ambari-agent,ambari-server -Del.log=OFF -DskipTests > -DassemblyPhase=none clean package > ... > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ........................................ SUCCESS [ 7.720 > s] > [INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.039 > s] > [INFO] Ambari Views ....................................... SUCCESS [ 1.584 > s] > [INFO] utility ............................................ SUCCESS [ 2.085 > s] > [INFO] ambari-metrics ..................................... SUCCESS [ 0.723 > s] > [INFO] Ambari Metrics Common .............................. SUCCESS [ 4.682 > s] > [INFO] Service Advisor .................................... SUCCESS [ 0.480 > s] > [INFO] Ambari Server ...................................... SUCCESS [01:15 > min] > [INFO] Ambari Agent ....................................... SUCCESS [ 14.341 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 01:47 min > ``` > > > Thanks, > > Attila Doroszlai > >
