-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60050/
-----------------------------------------------------------

(Updated June 16, 2017, 5:03 p.m.)


Review request for Ambari, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-21240
    https://issues.apache.org/jira/browse/AMBARI-21240


Repository: ambari


Description
-------

Remove orphaned `topology_logical_request` and `topology_request`.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 e0a496509e9256d5ca550e7dd79ae0cd0fb5882b 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java 
9152fd2fa4b2ff092abc53d636c2d429eda9e035 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
 eb1c3436db1055a798de69973ecc1ed5f967c5fa 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedState.java
 2989de64514a35c5db74a87d1b647f72f85a8c97 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/PersistedStateImpl.java
 a8b202e31b390f483d6ed1aee470179f519388a8 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
 8a22e53a7341b4ec6c8ec8b054319c2f4e3b27a8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
 1ca6a724782d9a38421ee9adcdcec2d956af7e92 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
 2dd45b73ad2d1047650f3b426df3cec54aed35a1 


Diff: https://reviews.apache.org/r/60050/diff/2/

Changes: https://reviews.apache.org/r/60050/diff/1-2/


Testing
-------

Functional test:

 * up/downscale by 1 host (verify topology request is removed)
 * upscale by 2 hosts, downscale by 1 host (verify topology request is retained)
 * upscale by 2 hosts with 1 pending, downscale by 1 host (verify topology 
request is retained)
 * upscale by 3 hosts with 1 pending, remove pending host assignments (verify 
topology request is retained)
 * upscale by 3 hosts with 3 pending, remove pending host assignments (verify 
topology request is removed)
 * restart Ambari Server (verify no database error reported)

Unit tests:

```
Tests run: 4982, Failures: 0, Errors: 0, Skipped: 39
```


Thanks,

Attila Doroszlai

Reply via email to