-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60164/#review178125
-----------------------------------------------------------



Received "+1" on apache jira: https://issues.apache.org/jira/browse/AMBARI-21273

- Jaimin Jetly


On June 16, 2017, 8:53 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60164/
> -----------------------------------------------------------
> 
> (Updated June 16, 2017, 8:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Sumit 
> Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21273
>     https://issues.apache.org/jira/browse/AMBARI-21273
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On executing mvn compile on ambari-server and then checking with git status, 
> following files are automatically added/edited even when no code changes are 
> made
> modified:   ambari-server/docs/api/generated/index.html
> 
> Untracked files:
>   (use "git add <file>..." to include in what will be committed)
> 
> docs/api/
> As a fix to this issue, swagger resources that are presently checked in to 
> ambari project at ambari-server/docs/api/generated/ will be updated only when 
> mvn command is executed with -Dgenerate.swagger.resources flag.
> This is expected to be done and resources should be checked in just before 
> every new ambari release. with this commit, ambari wiki page for release 
> guideline will also be updated
> 
> 
> Diffs
> -----
> 
>   ambari-server/pom.xml 91c35e5b50 
> 
> 
> Diff: https://reviews.apache.org/r/60164/diff/1/
> 
> 
> Testing
> -------
> 
> Tested by running "mvn clean test -Drat.skip -Dcheckstyle.skip -DskipTests" 
> and "mvn clean test -Drat.skip -Dcheckstyle.skip -DskipTests 
> -Dgenerate.swagger.resources" from ambari root project ane veroified behavior 
> is as expected
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to