-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60126/#review178253
-----------------------------------------------------------




ambari-server/src/main/python/ambari_server/serverUpgrade.py
Line 428 (original), 428 (patched)
<https://reviews.apache.org/r/60126/#comment252128>

    Any unit tests to cover this?


- Jayush Luniya


On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60126/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 5:11 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21263
>     https://issues.apache.org/jira/browse/AMBARI-21263
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {code}
> INFO: Loading properties from /etc/ambari-server/conf/ambari.properties
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 941, in <module>
>     mainBody()
>   File "/usr/sbin/ambari-server.py", line 911, in mainBody
>     main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 863, in main
>     action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 78, in execute
>     self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/serverUpgrade.py", 
> line 363, in upgrade
>     replay_mpack_logs()
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 983, in replay_mpack_logs
>     install_mpack(replay_options, replay_mode=True)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 896, in install_mpack
>     (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 792, in _install_mpack
>     process_service_definitions_artifact(artifact, artifact_source_dir, 
> options)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 515, in process_service_definitions_artifact
>     create_symlink(src_service_definitions_dir, dest_service_definitions_dir, 
> file, options.force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 235, in create_symlink
>     create_symlink_using_path(src_path, dest_link, force)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 247, in create_symlink_using_path
>     sudo.symlink(src_path, dest_link)
>   File "/usr/lib/python2.6/site-packages/resource_management/core/sudo.py", 
> line 123, in symlink
>     os.symlink(source, link_name)
> OSError: [Errno 17] File exists
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py b488ca6 
> 
> 
> Diff: https://reviews.apache.org/r/60126/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to