----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/#review178429 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py Lines 110 (patched) <https://reviews.apache.org/r/60249/#comment252386> Indentation looks off here, should be 2 spaces - Alejandro Fernandez On June 20, 2017, 9:17 p.m., Ambud Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60249/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 9:17 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Repository: ambari > > > Description > ------- > > Ambari rack awareness for Kafka. > https://issues.apache.org/jira/browse/AMBARI-21234 > > As an operations person it would be nice to manage Kafka rack awareness via > Ambari. Ambari allows node rack information to be configured and this > information can then be pulled in the Kafka stack and populated in the > server.properties file for Kafka. > Design: > This stack change uses the /clusterHostInfo/all_hosts and > /clusterHostInfo/all_racks paths and materializes them to a variable. Then it > uses linear search to find this node in the list of all hosts and it's > corresponding rack id. This information is then stored in a variable called > rack and which is materialized during the configure method of the broker > scripts. > This stack change relies on the node rack information stored in Ambari > therefore will enable both Ambari UI and Blueprints to be used for setting up > Kafka broker rack information. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py > 680dd32802 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 9acc1ef203 > > > Diff: https://reviews.apache.org/r/60249/diff/1/ > > > Testing > ------- > > Manually deployed Kafka cluster and verified the broker.rack property is > correctly populated. > > > Thanks, > > Ambud Sharma > >
