----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60201/#review178477 -----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java Line 324 (original), 324 (patched) <https://reviews.apache.org/r/60201/#comment252490> No need to discard - Dmytro Sen On Июнь 19, 2017, 7:14 п.п., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60201/ > ----------------------------------------------------------- > > (Updated Июнь 19, 2017, 7:14 п.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-17382 > https://issues.apache.org/jira/browse/AMBARI-17382 > > > Repository: ambari > > > Description > ------- > > With PHOENIX-914Link, there is a change in implementation , As earlier, > timestamp range was passed as a hint to the query to get advantage of native > timerange optimization in hbase but with new implementation we can mark the > timestamp column in the schema as a ROW_TIMESTAMP and pass timestamp range > with “where” clause only to achieve equivalent performance and better > accuracy. > > For ex:- > > With earlier implementation , AMS forms query like this:- > SELECT /*+ NATIVE_TIME_RANGE(1448029523000) */ METRIC_NAME, APP_ID, > INSTANCE_ID, SERVER_TIME, UNITS, METRIC_SUM, HOSTS_COUNT, METRIC_MAX, > METRIC_MIN FROM METRIC_AGGREGATE WHERE (METRIC_NAME IN > ('regionserver.Server.totalRequestCount', > 'regionserver.Server.blockCacheCountHitPercent', > 'regionserver.Server.regionCount', > 'regionserver.Server.compactionQueueLength', > 'regionserver.Server.storeFileCount', 'master.Server.averageLoad')) AND > APP_ID = 'ams-hbase' AND SERVER_TIME >= 1448029643000 AND SERVER_TIME < > 1448033243 ORDER BY METRIC_NAME, SERVER_TIME LIMIT 11520 > > > WORK DONE > 1. Removed START_TIME column from AMS schema and access layer. > 2. Removed timestamp field from TimelineMetric object. > 3. From now on, StartTime field in TimelineMetric object maps to > 'SERVER_TIME' in metric tables which are of type 'ROW_TIMESTAMP' > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/SingleValuedTimelineMetric.java > 4bb9355fa9408ac19899cc2c507f639c53951d30 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetric.java > 3d3b19ce6ef09b647125ee00c9e8d1c87d76c3cc > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TimelineMetrics.java > 383079a63cb2f89d6e71554000439f5b17aa253b > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsEhCacheSizeOfEngine.java > 0e23e17039359f73c40d2880465200be1dd5642f > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java > a290cedfc1307c38a340658e5302c095da0e36be > ambari-metrics/ambari-metrics-timelineservice/pom.xml > 34794e6f6b033400fc69bd87b3ba739bee2fb002 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > 7ad88a133b91dfc88434c80e05e50a1f2214d991 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > aa53430f9e784c8c5a5cf40de789e94319995518 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/AbstractTimelineAggregator.java > 83f2392d9f03fb534c4be0bd21511d4e28711a4b > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java > 0f6dd7904c74a5f97878c9015dadb3ccb2d2e679 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregatorSecond.java > cae72632024117f972f2a3b1232073595a8ea9df > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricHostAggregator.java > 8f941e1dfd708f1d54340d85c8f8bf7057f885da > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricReadHelper.java > c8b5728288d350d093254e310c7f012c6d2dff59 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricClusterAggregator.java > c7b605fc2e0f150c505aef207e99b3707042d832 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/v2/TimelineMetricHostAggregator.java > 57a3034d064f338aebb0096f3d0faca4a6e4390d > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 51c96c682f97b1ceb84d7dfe83f39d79680a4cf1 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java > 93242bdbbec44db9a4000ae54513a3552368ef47 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCache.java > a4ed9bc5f06ae53265e388d8c051af1f706317f5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TestApplicationHistoryServer.java > 41ddef5a19acf455fa953f78887ba77ebca37292 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/AbstractMiniHBaseClusterTest.java > fbf7b09c99907ae9adef6152107867fcbf82a4e5 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java > c25d4145e987b7f6d6c2786265ec886b33c3021d > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/MetricTestHelper.java > 7dfe1fcd6d93c37a61e29c593cdfcb4ab898bb08 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java > dd73a8aecfd2edfba9adc8b7b653dd0e1f74e3bc > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITClusterAggregator.java > e66e65db1a8c52cccb600f28da00d2c15862e937 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/ITMetricAggregator.java > 14ac4d7ec45c639c8cbfeb6fa87d9896ae087b68 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TestMetadataManager.java > ca1fc20b77071943e508349264c6cf47bd8437b0 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/RawMetricsSourceTest.java > 5d3aacb2b164b23916172bd86631eb841b63f287 > ambari-metrics/pom.xml 21608e4aff655abec24b7044e93b70d7e63e2867 > > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java > ecb59acd3e225c3e00cefab09aca29e1540c9cec > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/smoketest_metrics.json.j2 > 2ee0efa14d74ef39e816904df1d037eec620713a > > ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheSizingTest.java > fbc0b5694278f51bf2e6b79cc4d976307c8a9b60 > > > Diff: https://reviews.apache.org/r/60201/diff/1/ > > > Testing > ------- > > Manually tested. > mvn clean test on ambari-metrics. > > > Thanks, > > Aravindan Vijayan > >
