----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60248/#review178489 -----------------------------------------------------------
Ship it! Can we create a Jira to remove cluster.addService()? I know it's a lot of test code changes, so it can be in a different review. - Jonathan Hurley On June 20, 2017, 5:08 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60248/ > ----------------------------------------------------------- > > (Updated June 20, 2017, 5:08 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-21289 > https://issues.apache.org/jira/browse/AMBARI-21289 > > > Repository: ambari > > > Description > ------- > > Update the API for service use a desired repository id instead of a version > string. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 8d262e269b > > ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterRequest.java > ca6efa5b3c > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java > 10f8e812d0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceResponse.java > ffde416abc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 265b89b4d3 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > c97caeecd0 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 50847035e1 > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > 0467b9b859 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > c153381dc0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 240517f485 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > c0e3ef1578 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 3215e7246d > > ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java > e4f62790df > > ambari-server/src/test/java/org/apache/ambari/server/controller/RefreshYarnCapacitySchedulerReleaseConfigTest.java > b2589f6586 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > f436dcec4f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java > 4bb6524a08 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 2e98de9153 > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > 01a7532dc5 > > > Diff: https://reviews.apache.org/r/60248/diff/1/ > > > Testing > ------- > > Manual API. Automated: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 27:58 min > [INFO] Finished at: 2017-06-20T15:00:01-04:00 > [INFO] Final Memory: 79M/756M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
