----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60271/#review178494 -----------------------------------------------------------
Ship it! Ship It! - Balázs Bence Sári On June 21, 2017, 1 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60271/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 1 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Sumit Mohanty, > and Sebastian Toader. > > > Bugs: AMBARI-21295 > https://issues.apache.org/jira/browse/AMBARI-21295 > > > Repository: ambari > > > Description > ------- > > * Enabled `UndocumentedRestApiOperationCheck` > * Added `@ApiIgnore` for operations not yet documented > > > Diffs > ----- > > ambari-server/checkstyle.xml 97fdc2a91a467390df0213f720fb015cfd189df5 > > ambari-server/src/main/java/org/apache/ambari/server/agent/rest/AgentResource.java > a332459c91ae9af0314f7fc9f6d14acbe15c9cb1 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/BootStrapResource.java > 1bf22b176c182d50407efbb16e620d6fa9edae5f > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/HealthCheck.java > 4c7c5e873924e55df5e298558b30d29006ebe6e3 > > ambari-server/src/main/java/org/apache/ambari/server/api/rest/KdcServerReachabilityCheck.java > b4f1fe19236d0759f77a8c8e861efc8b485f0ee8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertDefinitionService.java > bf9741a81266c4327c5ac47f2f86211521ba1200 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertGroupService.java > be1c65c0b632b5daaf9040204ed21fed96388cf4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertHistoryService.java > 17733a257dff11429bf8fdbf56fb487926b1888b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertNoticeService.java > 2bbc51f5f2700217b6d916f75ec6e7a6f2bc1ab1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertService.java > 9922359e32f41f659eb4531c195490cea9a0bb5f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AlertTargetService.java > f00dfbb782a6e05e5104cdd926d35de88dbe6f41 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterKerberosDescriptorService.java > 0aeb52b7fba3c097102b9dbd9817323c84e0dfa2 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > eafc0760c482038c23ea09e9d97bf8381f6d7b1e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java > 5927f8b3189b563b684ef86b137c5693f4e2ff76 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java > 800e0119e9c4f4243ade500feb62dc59ce1e4900 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigGroupService.java > 5c52718a858c1eabfacb0ae937465c6f7952909f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ConfigurationService.java > c256ecae46bfb7ed81575c104d75b04e68c95e2a > > ambari-server/src/main/java/org/apache/ambari/server/api/services/CredentialService.java > 449c292c079493775a47a1462a5a1c617c6593e9 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionLinksService.java > 1acccd87c26fc1372e9686014f068d5f90efad65 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ExtensionsService.java > 2fedd54329d512c43b8ba79e9b20011e8a164abf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/FeedService.java > 73b99603bf63b89d9a96643a89d4a6a2d7660f23 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java > 62889722e5b15f26fcc3b5328f90a768c0a5a909 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostKerberosIdentityService.java > a99d269aa86f8021306a158a76eb915e5a81a418 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > bce51c490cff82d6bc56f336d5cce7b4344ea152 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/InstanceService.java > 760ee24dc7cd839dfc269985e387906e4cfcdcb7 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/JobService.java > bb882f12889c261cf0fd1aaf1f4d671d0c02e55f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/KerberosDescriptorService.java > 5f20c4f72044010da5673c29d19fa7d1d45ec2f1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/KeyService.java > 9ddcc79cd474f35aab47a21185ef941f6dc0a5cf > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LdapSyncEventService.java > cef4a60a6b1ad41b3b4d5be66c90bb8b8b2acaee > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java > a95aed8284d7c71ba8cbcc91cea54b9f208ab807 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LogoutService.java > f2f5e0e026ab504a161f3caca24b855adffa3b2d > > ambari-server/src/main/java/org/apache/ambari/server/api/services/OperatingSystemService.java > d6d786eca4eb1f3b9055e8f0cefbe6dca955994b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PermissionService.java > 18a32a15a7b9375f23bdf7229db5c2c87cb6d923 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PersistKeyValueService.java > 59b1d4e165c879aafcd7604ddad992ed8b098325 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PreUpgradeCheckService.java > c4127a8e301fdeb9229cd8734b229bca0a91d374 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/PrivilegeService.java > f16d24c88a16a860a6abce83f33789000904daa3 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RecommendationService.java > ce317b602c1c177c08534892f7c7e61394f2f5d8 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java > 2921cc4be8e798b488d3979cfd092a43c0387fdb > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryService.java > 4dc07f34d52b14da59142a4dab745076b0f67cbd > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java > c6d8935e7d8912e43309f6c416a2b533a36a9868 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestScheduleService.java > 5c48175a3e1b19f9ab79828f4f85c718345cc78b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RoleAuthorizationService.java > f7365a163054dba8b3bd62bc069303ca6de34014 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceConfigVersionService.java > 43eabdce8ae464140b9b791f141efe5bc58a0ea0 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StageService.java > 75163798dd48ba6dc18e1d1f7424429a0ea1f92c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/TargetClusterService.java > 88a27f2c3c7bb5059b93875bfa4317b3af7e9a27 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/TaskAttemptService.java > 55ff1ce718719fb817394d0a6f928891f633ce66 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/TaskService.java > 8441f7ee835f0ea908654aec0e3653fd3b05d1ad > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java > 004cd924bf62be777afa47aaf8269ebf8d1c0e82 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeItemService.java > 4e83de989713a6b342f37de6d0c180f7b4d5dd16 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeService.java > dd21a7d2bdb92eb3bfb6817a175eaf5550fc10fb > > ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeSummaryService.java > 9ed9e324c36e904f403f9e5284d1d37ec5c96e71 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ValidationService.java > 64cca7f1ce513fd277fc8198102ab26e07857b2e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/VersionDefinitionService.java > ce320036d9e94c11bd8fa537af123b0bbda9558e > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ViewUrlsService.java > 6bdf66dab09ab09571624521c4e67e1b2f182e4b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/WidgetLayoutService.java > b22ff4f5216b803dfa5415da7e768d2e82cf49c4 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/WidgetService.java > 32a985723f29d0281938cf00361ad0ce04a7f766 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/WorkflowService.java > b7e257a7ce49308889a5654bc27618fd03f102d1 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/GroupService.java > ede59b4aff9bcb853498a48db081669ea94ddb6f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/groups/MemberService.java > 765d0d3c4f771ebf29ec443ca0275d11ca89d477 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserService.java > ac6a055e22eb220c96e684a233613b07b53c380d > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewExternalSubResourceService.java > 9ce93bced162670db7210689830b2411a9e6558b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewInstanceService.java > 08e0e9fb5eecda5a822deb64806ae94e094aa025 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPermissionService.java > bdb67423b43ab751297b86cabd495e49aab63632 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewPrivilegeService.java > a2e8952458bb666b94ca95734739ddf8db05557b > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewService.java > a3da2127700769b2462377f1618afa1fb4ab744f > > ambari-server/src/main/java/org/apache/ambari/server/api/services/views/ViewVersionService.java > 90d5031239d1bb7cd86e75074de427b28abd2682 > > ambari-server/src/main/java/org/apache/ambari/server/proxy/ProxyService.java > 3237b367d350fbfd67fca749bb26a7e99e053948 > > ambari-server/src/main/java/org/apache/ambari/server/resources/api/rest/GetResource.java > f81c13a528f60bda9f5cb671a640760f00a3b422 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateDownload.java > eddc6bb8b9e8bb19c331617dcba792f13186ac35 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/CertificateSign.java > 5e2d45ac128b9c679dcacb58658772deae3e2bf2 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java > ac2e5364378bf3b7d167ff8fdb3472d0af22bce9 > > > Diff: https://reviews.apache.org/r/60271/diff/1/ > > > Testing > ------- > > ``` > $ mvn -am -pl ambari-server -DskipTests clean test > ... > [INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle) @ ambari-server --- > [INFO] Starting audit... > Audit done. > ... > [INFO] BUILD SUCCESS > ``` > > > Thanks, > > Attila Doroszlai > >
