----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60265/#review178503 -----------------------------------------------------------
Ship it! LGTM. Can you add a UI enginner (Vivek Subramanian or Richard Zang) to the review? - Aravindan Vijayan On June 21, 2017, 12:35 p.m., Jay SenSharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60265/ > ----------------------------------------------------------- > > (Updated June 21, 2017, 12:35 p.m.) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-21290 > https://issues.apache.org/jira/browse/AMBARI-21290 > > > Repository: ambari > > > Description > ------- > > In Ambari 2.5.1 when user try to access Grafana "Yarn Queue" dashboard it > throws error 400 Bad request. > This is because the startTime is formed incorrectly inside the dashboard.js. > > > Diffs > ----- > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js 72e64e2 > > > Diff: https://reviews.apache.org/r/60265/diff/2/ > > > Testing > ------- > > Manually tested, that after the mentioned fix in the "datasource.js" the > "startTime" value is getting generated properly. > > > Thanks, > > Jay SenSharma > >
