> On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 20 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line20> > > > > Please add the downgrade-allowed element set to false.
Will do. > On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 21 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line21> > > > > 2.6.2.* maybe? It should be 2.6.*.* in case we ever release HDP 2.6.3 or higher and the same upgrade pack is compatible. > On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 25-26 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line25> > > > > Are we dumping all version checks? We will continue to run all checks, but have a manual step to enable stack.upgrade.bypass.prechecks=true in ambari.properties file that will still show which PreChecks failed in the UI. There one PreCheck that we can use to ensure that they have deleted all other services. I will consider revising it if time permits. > On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 257 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line257> > > > > Ewww ... I forgot about this. Can you please check this class and see > > if it needs work to deal with stack name changes? If so, open a Jira to > > track. Will do > On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 485-497 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line485> > > > > Just remove it since don't support downgrade? Will remove it > On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 875-881 (patched) > > <https://reviews.apache.org/r/60477/diff/1/?file=1764264#file1764264line875> > > > > I think we need buy-in here; are we requiring SOLR to be removed before > > upgrade? > > Sid Wagle wrote: > Since we do not have SOLR definition in HDP stack it is safe to assume > the service should not exist. Good catch, will remove Solr as a service before the EU since it's included in Ambari Infra and doesn't participate in any orchestartion or hdp-select today. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60477/#review179021 ----------------------------------------------------------- On June 27, 2017, 6:24 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60477/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 6:24 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21350 > https://issues.apache.org/jira/browse/AMBARI-21350 > > > Repository: ambari > > > Description > ------- > > The following are requirements for this new upgrade pack: > Express upgrade only (no rolling upgrade packs) > There will be no stopping of components. Instead, the upgrade pack will begin > by moving the desired stack and then starting components > Downgrade should not be allowed > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/config-upgrade.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60477/diff/1/ > > > Testing > ------- > > Waiting for unit test results. > > > Thanks, > > Alejandro Fernandez > >
