----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60498/#review179096 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Grinenko On June 28, 2017, 12:27 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60498/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 12:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmytro Grinenko, Dmitro > Lisnichenko, and Jonathan Hurley. > > > Bugs: AMBARI-21362 > https://issues.apache.org/jira/browse/AMBARI-21362 > > > Repository: ambari > > > Description > ------- > > Check for source column existence, too. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessorImpl.java > 13e7d7d148795325cd0d1c698eae084f2f00a411 > > ambari-server/src/test/java/org/apache/ambari/server/orm/DBAccessorImplTest.java > ca2674c7109d8f2e4b75edbb85dbe5e05c8b1927 > > > Diff: https://reviews.apache.org/r/60498/diff/2/ > > > Testing > ------- > > Manually tested: > * real upgrade from 2.4.2 for any regression > * simulated retry: upgrade from 2.5.2 where metainfo says it's 2.5.0 > > New unit test. > > > Thanks, > > Attila Doroszlai > >
