> On June 28, 2017, 2:48 p.m., Jonathan Hurley wrote: > > Should this also be put into trunk? We would still need to support this > > moving forward. Maybe we need a Jira to track an actual property which > > governs which database executable to invoke. > > Di Li wrote: > An updated version should be pushed to trunk as HDP will probably have to > support Hive/MariaDB on migrated IOP clusters until all these clusters reach > the end of support terms. I can propose a new patch for trunk later on.
I just uploaded a new patch that uses a property to determine the daemon name - mysqld vs mariadb. If we use this new patch, it'd be easier for HDP to future support this migrated clusters ( same patch to be pushed to trunk, no need to have special change for the feature branch.) - Di ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179109 ----------------------------------------------------------- On June 28, 2017, 5:31 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60480/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 5:31 p.m.) > > > Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, > Jonathan Hurley, Sumit Mohanty, Sid Wagle, and Tim Thorpe. > > > Bugs: AMBARI-21351 > https://issues.apache.org/jira/browse/AMBARI-21351 > > > Repository: ambari > > > Description > ------- > > Some stacks, such as BigInights, support MariaDB as the database for Hive. > When upgrading from BigInights to another stack, such as HDP, this causes the > following exception when starting the Hive service: > ```resource_management.core.exceptions.ExecutionFailed: Execution of 'service > mysqld stop' returned 5. Redirecting to /bin/systemctl stop mysqld.service > Failed to stop mysqld.service: Unit mysqld.service not loaded.``` > This looks to be caused by the hard-coded reliance of mysqld in the Python > scripts. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > 1cf9016 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py > b7cb148 > > > Diff: https://reviews.apache.org/r/60480/diff/2/ > > > Testing > ------- > > Tim and I patched a cluster with basically the same fix when migrating an IOP > 4.2.5 cluster to HDP 2.6/Ambari 2.5.1. THis patch has one additional change > that's to set StackFeature boolean in case this code gets merged back to > trunk later on. > > If the code only stays in this branch, the StackFeature boolean change can be > omitted. > > > Thanks, > > Di Li > >
