-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60650/
-----------------------------------------------------------

Review request for Ambari and Oleg Nechiporenko.


Bugs: AMBARI-21403
    https://issues.apache.org/jira/browse/AMBARI-21403


Repository: ambari


Description
-------

- Incorrect request header is sent on login
- Login form is displayed to user on visiting the application page even if 
authorization is active
- AJAX requests are sent twice
- `FilterButtonComponent` fails to be compiled: `ERROR in No template specified 
for component FilterButtonComponent`
- JS error after login: `ERROR TypeError: Cannot read property 'timeZone' of 
undefined`, no content under navbar is displayed
- JS error on logs loading: `ERROR TypeError: Cannot read property 'map' of 
undefined`, no logs loaded as result
- URL params in logs request aren't encoded


Diffs
-----

  ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 1e0ebb0 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/accordion-panel/accordion-panel.component.ts
 85031b6 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.spec.ts
 3442132 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts 
c5a17c2 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/dropdown-list/dropdown-list.component.ts
 808fcf8 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-button/filter-button.component.ts
 3da53ca 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.spec.ts
 9f4522b 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-dropdown/filter-dropdown.component.ts
 84210dc 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.spec.ts
 740593f 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filter-text-field/filter-text-field.component.ts
 857b511 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html
 256b547 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts
 b2ae9b0 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.html
 37a96e9 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.spec.ts
 0498ee4 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.ts
 2a93775 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.html
 df72502 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-list/logs-list.component.ts
 efa05e4 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.html
 61d1b93 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.spec.ts
 536f1ef 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.ts
 bac39ec 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.spec.ts
 d53677d 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/components/menu-button/menu-button.component.ts
 08b555c 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/app-state.model.ts 
PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/models/store.model.ts 
c169c1b 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.spec.ts
 303fdab 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/component-actions.service.ts
 4cde0a0 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 
9f6b7dc 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.spec.ts
 083ea23 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/http-client.service.ts
 cef6696 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/mock-api-data.service.ts
 757f68d 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-settings.service.ts
 1c87a3c 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/app-state.service.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/audit-logs.service.ts
 7c322ed 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/bar-graphs.service.ts
 0109409 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/filters.service.ts
 b8748e9 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/graphs.service.ts
 eda04ee 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/nodes.service.ts
 7b2e6e9 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/service-logs.service.ts
 ba277c4 
  
ambari-logsearch/ambari-logsearch-web-new/src/app/services/storage/user-configs.service.ts
 b26485d 


Diff: https://reviews.apache.org/r/60650/diff/1/


Testing
-------

Executed 46 of 46 SUCCESS (1.287 secs / 1.257 secs)


Thanks,

Andrii Babiichuk

Reply via email to