----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60671/#review179751 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On July 5, 2017, 8:21 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60671/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 8:21 p.m.) > > > Review request for Ambari, Attila Doroszlai, Dmytro Grinenko, Jonathan > Hurley, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-21411 > https://issues.apache.org/jira/browse/AMBARI-21411 > > > Repository: ambari > > > Description > ------- > > During a cross-stack upgrade, the PreChecks need to be able to run. > > STR: > > * Install BigInsights 4.2.5 > * Upgrade Ambari to 2.5 > * Register bits for HDP 2.6 > * Install bits for HDP 2.6 > * Attempt to run PreChecks > > ``` > curl -u admin:admin -H "X-Requested-By: ambari" -i -X GET > http://localhost:8080/api/v1/clusters/c1/rolling_upgrades_check?fields=*&UpgradeChecks/repository_version=2.6.1.0-129&UpgradeChecks/upgrade_type=NON_ROLLING&UpgradeChecks/upgrade_pack=nonrolling-upgrade-to-hdp-2.6 > ``` > > This returns, > ``` > { > "status" : 500, > "message" : "org.apache.ambari.server.controller.spi.SystemException: > Repository version null was not found" > } > ``` > > because in UpgradeHelper.java it cannot find the upgrade pack. > > The new API will requiring passing in a new argument, e.g., > UpgradeChecks/target_stack=HDP-2.6 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java > 7ccafb7 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 795e8d1 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > 69663fb > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/FLUME/metainfo.xml > 99f1f79 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/JNBG/metainfo.xml > 3520a32 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/OOZIE/metainfo.xml > 4a7dc31 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/R4ML/metainfo.xml > d1c708d > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SOLR/metainfo.xml > be20810 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/SYSTEMML/metainfo.xml > 7a0e125 > > ambari-server/src/main/resources/stacks/BigInsights/4.2.5/services/TITAN/metainfo.xml > d00e707 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProviderTest.java > 47bba34 > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 6e27cba > > > Diff: https://reviews.apache.org/r/60671/diff/1/ > > > Testing > ------- > > Verified on local cluster > > > Thanks, > > Alejandro Fernandez > >
