----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60665/#review179760 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java Lines 29 (patched) <https://reviews.apache.org/r/60665/#comment254594> Shouldn't this return `AmbariConfigurationRequestInfo`? - Attila Doroszlai On July 5, 2017, 9:48 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60665/ > ----------------------------------------------------------- > > (Updated July 5, 2017, 9:48 p.m.) > > > Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and > Sebastian Toader. > > > Bugs: AMBARI-21307 > https://issues.apache.org/jira/browse/AMBARI-21307 > > > Repository: ambari > > > Description > ------- > > Added swagger annotations to the new AmbariConfigurationService class. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java > 0fa6e44 > > > Diff: https://reviews.apache.org/r/60665/diff/1/ > > > Testing > ------- > > Manually checked the generated html. > > > Thanks, > > Balázs Bence Sári > >
