-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60707/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy,
Jonathan Hurley, Laszlo Puskas, and Sebastian Toader.
Bugs: AMBARI-20861
https://issues.apache.org/jira/browse/AMBARI-20861
Repository: ambari
Description
-------
Update the Ambari REST API to allow for GET, POST, PUT, and DELETE operations
on the authentication sources related to an Ambari user account.
Add the following entry points:
- `/api/v1/users/:USER_ID`
-- Get a user
-- Modify a user
- `/api/v1/users/:USERNAME/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user
- `/api/v1/users/:USERNAME/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user
- `/api/v1/users/:USER_ID/sources`
-- List a user’s authentication sources
-- Add a new authentication source for a user
- `/api/v1/users/:USER_ID/sources/:SOURCE_ID`
-- Get details on a specific authentication source for a user
-- Modify details for a specific authentication source for a user
Update the following entry points, ensuring backwards compatibility where
possible:
- `/api/v1/users`
-- List all users
-- Add a new user
-- Backward compatibility: Set password should create or update the appropriate
user_authentication record.
Diffs
-----
ambari-server/docs/api/v1/authentication-source-create.md PRE-CREATION
ambari-server/docs/api/v1/authentication-source-delete.md PRE-CREATION
ambari-server/docs/api/v1/authentication-source-get.md PRE-CREATION
ambari-server/docs/api/v1/authentication-source-list.md PRE-CREATION
ambari-server/docs/api/v1/authentication-source-resources.md PRE-CREATION
ambari-server/docs/api/v1/authentication-source-update.md PRE-CREATION
ambari-server/docs/api/v1/index.md da05d75bc3
ambari-server/docs/api/v1/user-create.md PRE-CREATION
ambari-server/docs/api/v1/user-delete.md PRE-CREATION
ambari-server/docs/api/v1/user-get.md PRE-CREATION
ambari-server/docs/api/v1/user-list.md PRE-CREATION
ambari-server/docs/api/v1/user-resources.md PRE-CREATION
ambari-server/docs/api/v1/user-update.md PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
96e288fee0
ambari-server/src/main/java/org/apache/ambari/server/api/resources/UserResourceDefinition.java
b228c82aa9
ambari-server/src/main/java/org/apache/ambari/server/api/services/users/UserAuthenticationSourceService.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
25d12c7dd6
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
2454bf7694
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceRequest.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/UserAuthenticationSourceResponse.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/UserResponse.java
bcb3aaf3e1
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
595b7f996f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProvider.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserResourceProvider.java
45b733b042
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
362b4e631c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java
5ecff52ab2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java
ffb8e6dd16
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
de12a1669f
ambari-server/src/main/resources/properties.json 11ca7f678a
ambari-server/src/test/java/org/apache/ambari/server/api/resources/UserResourceDefinitionTest.java
024b118a9c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
3becc02aa8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthenticationSourceResourceProviderTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderDBTest.java
db7548f077
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
4530d40ce4
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
43d56cd473
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
e049b4e83b
Diff: https://reviews.apache.org/r/60707/diff/1/
Testing
-------
Manaully tested using REST API testing tool.
# Local test results
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29:37 min
[INFO] Finished at: 2017-07-07T07:47:34-04:00
[INFO] Final Memory: 108M/1769M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
